You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "Jefffrey (via GitHub)" <gi...@apache.org> on 2023/04/03 21:18:00 UTC

[GitHub] [arrow-datafusion] Jefffrey commented on a diff in pull request #5778: feat: Quote column names if required in error messages

Jefffrey commented on code in PR #5778:
URL: https://github.com/apache/arrow-datafusion/pull/5778#discussion_r1156460074


##########
datafusion/common/src/table_reference.rs:
##########
@@ -272,14 +272,14 @@ impl<'a> TableReference<'a> {
     /// ```
     /// # use datafusion_common::TableReference;
     /// let table_reference = TableReference::partial("myschema", "mytable");
-    /// assert_eq!(table_reference.to_quoted_string(), r#""myschema"."mytable""#);
+    /// assert_eq!(table_reference.to_quoted_string(), r#"myschema.mytable"#);

Review Comment:
   ```suggestion
       /// assert_eq!(table_reference.to_quoted_string(), "myschema.mytable");
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org