[GitHub] [mina-sshd] tomaswolf commented on issue #297: SSHD Client failing on private key file with key password

[GitBox <gi...@apache.org>]

tomaswolf commented on issue #297:
URL: https://github.com/apache/mina-sshd/issues/297#issuecomment-1361969405

   If you mean that you added in [SshClientCliSupport, line 508](https://github.com/apache/mina-sshd/blob/78ed6bc9/sshd-cli/src/main/java/org/apache/sshd/cli/client/SshClientCliSupport.java#L508) something like
   ```
   provider.setPasswordFinder(client.getFilePasswordProvider());
   ```
   I agree that this is one way of solving this.
   
   However, I wonder if this was not better done automatically in [SshClient](https://github.com/apache/mina-sshd/blob/78ed6bc9/sshd-core/src/main/java/org/apache/sshd/client/SshClient.java#L755) by making sure the session's effective keypair provider does have a password finder set.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org