[jira] [Commented] (SHIRO-587) Can't Access Groups If userPrincipalName Doesn't Exist

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SHIRO-587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15531326#comment-15531326 ] 

ASF GitHub Bot commented on SHIRO-587:
--------------------------------------

GitHub user opticyclic opened a pull request:

    https://github.com/apache/shiro/pull/40

    SHIRO-587 - Expose searchFilter as a property that can be set in the ini

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/opticyclic/shiro SHIRO-587_ExposeSearchFilter

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/shiro/pull/40.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #40
    
----
commit d302523b79fc4bd86ba3449618ee138f715d1d42
Author: andrewmorgan <an...@formicary.net>
Date:   2016-09-28T23:03:54Z

    SHIRO-587 - Expose searchFilter as a property that can be set in the ini

----


> Can't Access Groups If userPrincipalName Doesn't Exist
> ------------------------------------------------------
>
>                 Key: SHIRO-587
>                 URL: https://issues.apache.org/jira/browse/SHIRO-587
>             Project: Shiro
>          Issue Type: Bug
>            Reporter: opticyclic
>            Priority: Blocker
>
> Sometimes you need to use sAMAccountName instead of userPrincipalName in your search.
> However, this is hard-coded in a private method
> https://github.com/apache/shiro/blob/master/core/src/main/java/org/apache/shiro/realm/activedirectory/ActiveDirectoryRealm.java#L171
> See here for a similar question on stackoverflow
> http://stackoverflow.com/questions/24062383/shiro-ldap-authorization-config/34896329#34896329
> There is a similar bug in Spring Security
> https://github.com/spring-projects/spring-security/issues/2448
> Making the search query was configurable in the shiro.ini would be useful.
> Making the getRoleNamesForUser protected instead of private would make sub-classing easier.
> Or keep the method private but make a protected method that returns Object[] searchArguments.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)