You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@shindig.apache.org by mh...@apache.org on 2011/05/10 04:56:43 UTC

svn commit: r1101291 - in /shindig/trunk/features/src/main/javascript/features/rpc: feature.xml rpc.js

Author: mhermanto
Date: Tue May 10 02:56:43 2011
New Revision: 1101291

URL: http://svn.apache.org/viewvc?rev=1101291&view=rev
Log:
Have gadgets.rpc use the new XHTML-based iframe creation.
http://codereview.appspot.com/4515055/

Modified:
    shindig/trunk/features/src/main/javascript/features/rpc/feature.xml
    shindig/trunk/features/src/main/javascript/features/rpc/rpc.js

Modified: shindig/trunk/features/src/main/javascript/features/rpc/feature.xml
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/rpc/feature.xml?rev=1101291&r1=1101290&r2=1101291&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/rpc/feature.xml (original)
+++ shindig/trunk/features/src/main/javascript/features/rpc/feature.xml Tue May 10 02:56:43 2011
@@ -21,7 +21,8 @@ specific language governing permissions 
   <dependency>globals</dependency>
   <dependency>core.config.base</dependency>
   <dependency>core.json</dependency>
-  <dependency>core.util.urlparams</dependency>
+  <!-- TODO: only depend on core.util.dom and core.util.urlparams -->
+  <dependency>core.util</dependency>
   <all>
     <api>
       <exports type="js">gadgets.rpc.config</exports>

Modified: shindig/trunk/features/src/main/javascript/features/rpc/rpc.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/rpc/rpc.js?rev=1101291&r1=1101290&r2=1101291&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/rpc/rpc.js (original)
+++ shindig/trunk/features/src/main/javascript/features/rpc/rpc.js Tue May 10 02:56:43 2011
@@ -1020,7 +1020,7 @@ if (!window['gadgets']['rpc']) { // make
         var src = relay + '#..&' + rpcId + '&' + token + '&' +
             encodeURIComponent(gadgets.json.stringify(data));
 
-        var iframe = document.createElement('iframe');
+        var iframe = gadgets.util.createIframeElement();
         iframe.style.border = iframe.style.width = iframe.style.height = '0px';
         iframe.style.visibility = 'hidden';
         iframe.style.position = 'absolute';