Re: [PR] [CELEBORN-1974] ApplicationId as metrics label should be behind a config flag [celeborn]

["RexXiong (via GitHub)" <gi...@apache.org>]

RexXiong commented on code in PR #3221:
URL: https://github.com/apache/celeborn/pull/3221#discussion_r2079235703


##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -5594,6 +5598,16 @@ object CelebornConf extends Logging {
       .booleanConf
       .createWithDefault(true)
 
+  val METRICS_LABEL_APPLICATION_ID: ConfigEntry[Boolean] =
+    buildConf("celeborn.metrics.label.applicationId")

Review Comment:
   How about use name `celeborn.metrics.worker.appLevel.enabled`



##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/WorkerSource.scala:
##########
@@ -108,6 +109,7 @@ class WorkerSource(conf: CelebornConf) extends AbstractSource(conf, Role.WORKER)
   }
 
   def recordAppActiveConnection(client: TransportClient, shuffleKey: String): Unit = {
+    if (!metricsLabelApplicationId) return

Review Comment:
   should also modify `removeAppActiveConnection`、`connectionActive`、`connectionInactive`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org