You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/09/03 11:10:24 UTC
[GitHub] [incubator-seatunnel] CalvinKirs opened a new pull request, #2630: [#2606]Dependency management split
CalvinKirs opened a new pull request, #2630:
URL: https://github.com/apache/incubator-seatunnel/pull/2630
#2606 subtask
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a diff in pull request #2630: [#2606]Dependency management split
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on code in PR #2630:
URL: https://github.com/apache/incubator-seatunnel/pull/2630#discussion_r962427455
##########
seatunnel-connectors/seatunnel-connectors-spark/seatunnel-connector-spark-http/pom.xml:
##########
@@ -25,8 +25,26 @@
<artifactId>seatunnel-connectors-spark</artifactId>
<version>${revision}</version>
</parent>
- <modelVersion>4.0.0</modelVersion>
<artifactId>seatunnel-connector-spark-http</artifactId>
+
+ <properties>
+ <httpcore.version>4.4</httpcore.version>
+ <httpclient.version>4.5.13</httpclient.version>
+ </properties>
+ <modelVersion>4.0.0</modelVersion>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.httpcomponents</groupId>
+ <artifactId>httpcore</artifactId>
+ <version>${httpcore.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.httpcomponents</groupId>
+ <artifactId>httpclient</artifactId>
+ <version>${httpclient.version}</version>
+ </dependency>
Review Comment:
hi, the http dependency plugin is actually a required option, and it was previously provided as a provide item. When we extract it to the parent dependency and provide it as a provider, it will have problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X commented on pull request #2630: [#2606]Dependency management split
Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on PR #2630:
URL: https://github.com/apache/incubator-seatunnel/pull/2630#issuecomment-1236491355
seem like ci have some problem should be fixed before merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on a diff in pull request #2630: [#2606]Dependency management split
Posted by GitBox <gi...@apache.org>.
hailin0 commented on code in PR #2630:
URL: https://github.com/apache/incubator-seatunnel/pull/2630#discussion_r962145157
##########
seatunnel-connectors/seatunnel-connectors-spark/seatunnel-connector-spark-http/pom.xml:
##########
@@ -25,8 +25,26 @@
<artifactId>seatunnel-connectors-spark</artifactId>
<version>${revision}</version>
</parent>
- <modelVersion>4.0.0</modelVersion>
<artifactId>seatunnel-connector-spark-http</artifactId>
+
+ <properties>
+ <httpcore.version>4.4</httpcore.version>
+ <httpclient.version>4.5.13</httpclient.version>
+ </properties>
+ <modelVersion>4.0.0</modelVersion>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.httpcomponents</groupId>
+ <artifactId>httpcore</artifactId>
+ <version>${httpcore.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.httpcomponents</groupId>
+ <artifactId>httpclient</artifactId>
+ <version>${httpclient.version}</version>
+ </dependency>
Review Comment:
Where did it move from?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #2630: [#2606]Dependency management split
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on PR #2630:
URL: https://github.com/apache/incubator-seatunnel/pull/2630#issuecomment-1236483903
> Hi, all `seatunnel-api` in `connector-v2` the scope should be `provided`
Hi, thx your reminder. done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X commented on pull request #2630: [#2606]Dependency management split
Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on PR #2630:
URL: https://github.com/apache/incubator-seatunnel/pull/2630#issuecomment-1236109071
Hi, all `seatunnel-api` in `connector-v2` the scope should be `provided`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #2630: [#2606]Dependency management split
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on PR #2630:
URL: https://github.com/apache/incubator-seatunnel/pull/2630#issuecomment-1236502545
> seem like ci have some problem should be fixed before merge.
hi, done.This is due to provide dependency transitivity, so I added the dependency of seatunnel-api in the parent pom
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X merged pull request #2630: [#2606]Dependency management split
Posted by GitBox <gi...@apache.org>.
Hisoka-X merged PR #2630:
URL: https://github.com/apache/incubator-seatunnel/pull/2630
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org