svn commit: r892883 - in /myfaces/extensions/scripting/trunk/core/core/src: main/java/org/apache/myfaces/scripting/core/dependencyScan/ClassLogUtils.java test/java/org/apache/myfaces/extensions/scripting/dependencyScan/DependencyScannerTest.java

[we...@apache.org]

Author: werpu
Date: Mon Dec 21 17:07:17 2009
New Revision: 892883

URL: http://svn.apache.org/viewvc?rev=892883&view=rev
Log:
https://issues.apache.org/jira/browse/EXTSCRIPT-39

added comment

Modified:
    myfaces/extensions/scripting/trunk/core/core/src/main/java/org/apache/myfaces/scripting/core/dependencyScan/ClassLogUtils.java
    myfaces/extensions/scripting/trunk/core/core/src/test/java/org/apache/myfaces/extensions/scripting/dependencyScan/DependencyScannerTest.java

Modified: myfaces/extensions/scripting/trunk/core/core/src/main/java/org/apache/myfaces/scripting/core/dependencyScan/ClassLogUtils.java
URL: http://svn.apache.org/viewvc/myfaces/extensions/scripting/trunk/core/core/src/main/java/org/apache/myfaces/scripting/core/dependencyScan/ClassLogUtils.java?rev=892883&r1=892882&r2=892883&view=diff
==============================================================================
--- myfaces/extensions/scripting/trunk/core/core/src/main/java/org/apache/myfaces/scripting/core/dependencyScan/ClassLogUtils.java (original)
+++ myfaces/extensions/scripting/trunk/core/core/src/main/java/org/apache/myfaces/scripting/core/dependencyScan/ClassLogUtils.java Mon Dec 21 17:07:17 2009
@@ -113,11 +113,15 @@
 
     /**
      * logs a dependency if it does not belong to the standard namespaces
+     * and also it only is added if it belongs to our whitelist of
+     * non standard namespaces (the standard check is just a short circuiting
+     * for performance reasons, before going into the heavier whitelist
+     * namespace check)
      *
      * @param dependencies the target which has to recieve the dependency in source format
      * @param parms        the list of dependencies which have to be added
      */
-    public static final void logParmList(Collection<String> dependencies, Set<String> whiteList, String... parms) {
+    public static final void logParmList(Collection<String> dependencies,final Set<String> whiteList,final String... parms) {
         for (String parm : parms) {
             if (parm == null) continue;
             if (parm.equals("")) continue;

Modified: myfaces/extensions/scripting/trunk/core/core/src/test/java/org/apache/myfaces/extensions/scripting/dependencyScan/DependencyScannerTest.java
URL: http://svn.apache.org/viewvc/myfaces/extensions/scripting/trunk/core/core/src/test/java/org/apache/myfaces/extensions/scripting/dependencyScan/DependencyScannerTest.java?rev=892883&r1=892882&r2=892883&view=diff
==============================================================================
--- myfaces/extensions/scripting/trunk/core/core/src/test/java/org/apache/myfaces/extensions/scripting/dependencyScan/DependencyScannerTest.java (original)
+++ myfaces/extensions/scripting/trunk/core/core/src/test/java/org/apache/myfaces/extensions/scripting/dependencyScan/DependencyScannerTest.java Mon Dec 21 17:07:17 2009
@@ -41,8 +41,13 @@
         whiteList.add("org.apache.xxx");
         whiteList.add("org.apache.myfaces.extensions.scripting");
 
+        //long before = System.currentTimeMillis();
 
         Set<String> retVal = (new DefaultDependencyScanner()).fetchDependencies("org.apache.myfaces.extensions.scripting.dependencyScan.probes.Probe", whiteList);
+        //long after = System.currentTimeMillis();
+
+        //System.out.println(after-before);
+
         assertTrue(retVal.size() > 0);
 
         assertFalse(retVal.contains("java.lang.String"));