You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2022/04/07 15:19:40 UTC

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4273: HBASE-26807 Unify CallQueueTooBigException special pause with CallDroppedException

bbeaudreault commented on code in PR #4273:
URL: https://github.com/apache/hbase/pull/4273#discussion_r845262415


##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncConnectionConfiguration.java:
##########
@@ -118,50 +95,45 @@
   private final int maxKeyValueSize;
 
   AsyncConnectionConfiguration(Configuration conf) {
+    ConnectionConfiguration connectionConf = new ConnectionConfiguration(conf);

Review Comment:
   note this difference between master and branch-2 -- since we must maintain both an async and blocking configuration, I pulled this in here to DRY up the handling (and remove the duplicate logging)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org