You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "Siddharth Wagle (Jira)" <ji...@apache.org> on 2020/02/25 00:08:00 UTC
[jira] [Comment Edited] (HDDS-3038) TestRatisPipelineLeader fails
since we no longer wait for leader in the HealthyPipelineSafeModeExitRule
[ https://issues.apache.org/jira/browse/HDDS-3038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17043972#comment-17043972 ]
Siddharth Wagle edited comment on HDDS-3038 at 2/25/20 12:07 AM:
-----------------------------------------------------------------
Hi [~adoroszlai]. This regression is caused by recent feature merge of multi-raft, the HealthyPipelineSafeModeRule no longer waits for pipeline leader to become available, verified in the isHealthy() method or checking the report has leader info. cc:[~timmylicheng]/[~sammichen]
I am making a fix to retain what has been changed, whether to wait for leader or not was always debatable but now that we have multi-raft maybe it is not entirely necessary to wait on it. Thoughts are welcome. cc: [~nanda] Although, right now we do move from ALLOCATED to OPEN only after leader election in PipelineReportHandler, so whether safe should exit or not is a the real question.
was (Author: swagle):
Hi [~adoroszlai]. This regression is caused by recent feature merge of multi-raft, the HealthyPipelineSafeModeRule no longer waits for pipeline leader to become available, verified in the isHealthy() method or checking the report has leader info. cc:[~timmylicheng]/[~sammichen]
I am making a fix to retain what has been changed, whether to wait for leader or not was always debatable but now that we have multi-raft maybe it is not entirely necessary to wait on it.
> TestRatisPipelineLeader fails since we no longer wait for leader in the HealthyPipelineSafeModeExitRule
> -------------------------------------------------------------------------------------------------------
>
> Key: HDDS-3038
> URL: https://issues.apache.org/jira/browse/HDDS-3038
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: test
> Reporter: Attila Doroszlai
> Assignee: Siddharth Wagle
> Priority: Major
>
> {code:title=https://github.com/apache/hadoop-ozone/runs/456217344}
> [ERROR] Tests run: 2, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 29.823 s <<< FAILURE! - in org.apache.hadoop.hdds.scm.TestRatisPipelineLeader
> [ERROR] testLeaderIdAfterLeaderChange(org.apache.hadoop.hdds.scm.TestRatisPipelineLeader) Time elapsed: 5.367 s <<< FAILURE!
> java.lang.AssertionError
> ...
> at org.apache.hadoop.hdds.scm.TestRatisPipelineLeader.verifyLeaderInfo(TestRatisPipelineLeader.java:125)
> at org.apache.hadoop.hdds.scm.TestRatisPipelineLeader.testLeaderIdAfterLeaderChange(TestRatisPipelineLeader.java:106)
> [ERROR] testLeaderIdUsedOnFirstCall(org.apache.hadoop.hdds.scm.TestRatisPipelineLeader) Time elapsed: 0.008 s <<< FAILURE!
> java.lang.AssertionError
> ...
> at org.apache.hadoop.hdds.scm.TestRatisPipelineLeader.verifyLeaderInfo(TestRatisPipelineLeader.java:125)
> at org.apache.hadoop.hdds.scm.TestRatisPipelineLeader.testLeaderIdUsedOnFirstCall(TestRatisPipelineLeader.java:76)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org