[GitHub] [arrow-datafusion] yjshen commented on pull request #1596: Consolidate sort and external_sort, consolidate N-way merge sort

[GitBox <gi...@apache.org>]

yjshen commented on pull request #1596:
URL: https://github.com/apache/arrow-datafusion/pull/1596#issuecomment-1015165921


   I first run bench `sort_limit_query_sql`
   ```
   cargo criterion --bench sort_limit_query_sql
   ```
    and witness no noticeable difference between this branch with which it [originates](https://github.com/apache/arrow-datafusion/tree/438b41749c5cf9db68e431557b3bea01aec74af9):
   
   With this PR: 
   ```
   sort_and_limit_by_int   time:   [3.3633 ms 3.4736 ms 3.6268 ms]                                   
   
   sort_and_limit_by_float time:   [3.3644 ms 3.4726 ms 3.6342 ms]
   
   sort_and_limit_lex_by_int                                                                             
                           time:   [3.7431 ms 4.1084 ms 4.6626 ms]
   
   sort_and_limit_lex_by_string                                                                             
                           time:   [3.4665 ms 3.6071 ms 3.7919 ms]
   
   ```
   
   Without this PR:
   ```
   sort_and_limit_by_int   time:   [3.3156 ms 3.3392 ms 3.3626 ms]
   
   sort_and_limit_by_float time:   [3.2272 ms 3.6257 ms 4.3373 ms]
   
   sort_and_limit_lex_by_int
                           time:   [3.4235 ms 3.4393 ms 3.4558 ms]
   
   sort_and_limit_lex_by_string
                           time:   [3.3962 ms 3.4127 ms 3.4298 ms]
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org