You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by astroshim <gi...@git.apache.org> on 2015/11/21 17:38:20 UTC

[GitHub] incubator-zeppelin pull request: Improve storing notebook.

GitHub user astroshim opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/457

    Improve storing notebook.

    This PR relates to: https://issues.apache.org/jira/browse/ZEPPELIN-454
    Storing the notebook process changed. (store".note.json" temporary file first and if  it is succeed ".note.json" move to "note.json")


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/astroshim/incubator-zeppelin issue-454

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/457.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #457
    
----
commit 5a66bff0ccc904e79c22a178191008b1f6418996
Author: astroshim <hs...@nflabs.com>
Date:   2015-11-21T16:27:59Z

    change way storing notebook.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Improve storing notebook.

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/457#issuecomment-159354344
  
    I think it adds value (prevent corruption of note.json when saving).
    I think restoring .note.json (when possible) could be a future work.
    
    Looks good to me.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Improve storing notebook.

Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/457#issuecomment-158737852
  
    @khalidhuseynov it's good to know, but could you add a couple of words explaining why is that? :)
    
    Nobody thinks that we also should have a recovery from .note.json state? Sorry if I'm missing something obvious here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Improve storing notebook.

Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/457#issuecomment-158828346
  
    sure @bzz so it doesn't affect sync since it just changes the way note.json saves to local fs (since in `VFSNotebookRepo`), making `note.json` either valid or non-saved (excluding the case of broken `note.json`). So in case of exception with local saving `.note.json`,  the real `note.json` isn't saved as expected and exception is thrown.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Improve storing notebook.

Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/457#issuecomment-158733684
  
    LGTM, @bzz it doesn't affect sync between repos


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Improve storing notebook.

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/457#issuecomment-158699413
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Improve storing notebook.

Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/457#issuecomment-159449913
  
    Sounds good


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Improve storing notebook.

Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/457#issuecomment-158706111
  
    Shall not we have an error handling in case if .note.json -> note.json fails? I.e next time when zeppelin starts and have .note.json it could recover privious state, what do you think?
    
    I'm not sure if I understand so could you let me know if this change also impact sync between notebook repos?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Improve storing notebook.

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-zeppelin/pull/457


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Improve storing notebook.

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/457#issuecomment-159781798
  
    Thanks, then i'm merging it into the master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Improve storing notebook.

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/457#issuecomment-158738079
  
    To recover from `.note.json`, it should validate `.note.json` first, while it's possible to have broken json string.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---