[kudu-CR] WIP: flatbuffers-based codegen

["Anonymous Coward (Code Review)" <ge...@cloudera.org>]

Anonymous Coward #174 has posted comments on this change.

Change subject: WIP: flatbuffers-based codegen
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2903/2/src/kudu/codegen/row_projector.cc
File src/kudu/codegen/row_projector.cc:

Line 283: // TODO: this can be implemented with EncodeFlatBuf, except that currently
        :   // a single flatbuf is either read _or_ write, whereas here we really need
        :   // to get _both_ defaults.
You could just call EncodeFlatBuf with is_read turned on, then off (would duplicate some of the values but code would be simpler).

If the two schemas take up too much space (though I don't recall this being a problem), you can run the key through a 128-bit hash and then just use that as the key itself.

(you can get rid of AddNext if you do this)


-- 
To view, visit http://gerrit.cloudera.org:8080/2903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I583ef1edad379bb13b34362f121263de28c8334c
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Anonymous Coward #174
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes