You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2021/11/02 21:51:56 UTC
[GitHub] [systemds] phaniarnab commented on a change in pull request #1432: [MINOR] Python `SYSTEMDS_BIN` update for all the version types
phaniarnab commented on a change in pull request #1432:
URL: https://github.com/apache/systemds/pull/1432#discussion_r741478323
##########
File path: src/main/python/pre_setup.py
##########
@@ -39,7 +39,7 @@
shutil.rmtree(TMP_DIR, True)
os.mkdir(TMP_DIR)
-SYSTEMDS_BIN = 'systemds-*-SNAPSHOT-bin.zip'
+SYSTEMDS_BIN = 'systemds-*-bin.zip'
Review comment:
This change leads to test failure. That is why I suggested using `sed `to do it only during release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org