You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/31 08:17:59 UTC

[GitHub] [arrow-rs] tustvold commented on pull request #1767: Remove `validate_decimal_precision` check in `DecimalBuilder.append_value`

tustvold commented on PR #1767:
URL: https://github.com/apache/arrow-rs/pull/1767#issuecomment-1141812467

   I'm not sure how I feel about this, the promise of the builders is they won't let you construct an ArrayData that would fail validation, and can therefore elide this validation. I think this change violates that?
   
   Tbh this feels like a bug in the C++ implementation... Perhaps we should raise a ticket to at the very least get context?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org