You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/06 01:59:26 UTC

[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #15718: [fix][schema] Fix update schema forward compatibility strategy behavior

Demogorgon314 commented on code in PR #15718:
URL: https://github.com/apache/pulsar/pull/15718#discussion_r889775229


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/SchemaRegistryServiceImpl.java:
##########
@@ -178,15 +178,8 @@ public CompletableFuture<List<CompletableFuture<SchemaAndMetadata>>> getAllSchem
     @NotNull
     public CompletableFuture<SchemaVersion> putSchemaIfAbsent(String schemaId, SchemaData schema,

Review Comment:
   @congbobo184 
   I see. In the current implementation this is correct behavior, right? 
   
   Maybe we should let `createSchema` method return the version of the schema, so users can see whether the schema is changed or not? If this change makes sense, I'll draft a proposal to introduce a new `createOrUpdateSchema` admin API, it can able to return the schema version.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org