You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@avro.apache.org by GitBox <gi...@apache.org> on 2020/05/27 07:29:07 UTC

[GitHub] [avro] maccamlc commented on pull request #884: AVRO-2837: DecimalConversion handling of scale and precision

maccamlc commented on pull request #884:
URL: https://github.com/apache/avro/pull/884#issuecomment-634481609


   > Hello! Thanks for noticing these issues. Avro is definitely doing something wrong today, with precisions that don't match the logical type.
   > 
   > However, there's something wrong with your logic here: if the logical type is precision 5 and scale 2, it would happily accept a `new BigDecimal("9123")` (precision 4 and scale 0). I tried to exhaustively list the cases in [AVRO-2837](https://issues.apache.org/jira/browse/AVRO-2837), and there's a decision to be made about _how_ this should be fixed! Can you take a look?
   
   Thanks for the feedback @RyanSkraba . I've made some updates and commented on [AVRO-2837](https://issues.apache.org/jira/browse/AVRO-2837)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org