some Cygwin 12d warnings

[Mark Brown <mb...@inbox.com>]

Okay, after I took out the -fPIC flag to get rid of the pesky warnings the library build went fine with just a couple of warnings. What's the policy when it comes to warnings? Are some warnings expected or are builds supposed to be completely clean?

gcc -c -I/home/mbrown/stdcxx/include/ansi   -mthreads -D_RWSTD_USE_CONFIG -I/home/mbrown/stdcxx/include -I/home/mbrown/stdcxx-12d/include  -pedantic -nostdinc++ -O2  -W -Wall -Wcast-qual -Winline -Wshadow -Wwrite-strings -Wno-long-long -Wcast-align    /home/mbrown/stdcxx/src/collate.cpp
/home/mbrown/stdcxx/src/collate.cpp: In member function `virtual std::basic_string<char, std::char_traits<char>, std::allocator<char> > std::collate_byname<char>::do_transform(const char*, const char*) const':
/home/mbrown/stdcxx/src/collate.cpp:484: warning: 'pbuf' might be used uninitialized in this function
/home/mbrown/stdcxx/src/collate.cpp: In member function `virtual std::basic_string<wchar_t, std::char_traits<wchar_t>, std::allocator<wchar_t> > std::collate_byname<wchar_t>::do_transform(const wchar_t*, const wchar_t*) const':
/home/mbrown/stdcxx/src/collate.cpp:687: warning: 'pbuf' might be used uninitialized in this function

And also:

gcc -c -I/home/mbrown/stdcxx/include/ansi   -mthreads -D_RWSTD_USE_CONFIG -I/home/mbrown/stdcxx/include -I/home/mbrown/stdcxx-12d/include  -pedantic -nostdinc++ -O2  -W -Wall -Wcast-qual -Winline -Wshadow -Wwrite-strings -Wno-long-long -Wcast-align    /home/mbrown/stdcxx/src/iostore.cpp
/home/mbrown/stdcxx/src/iostore.cpp: In member function `void std::ios_base::_C_copyfmt(const std::ios_base&, void*, const void*, unsigned int)':
/home/mbrown/stdcxx/src/iostore.cpp:187: warning: 'except' might be used uninitialized in this function


-- Mark

Re: some Cygwin 12d warnings

[Martin Sebor <se...@roguewave.com>]

Mark Brown wrote:
> Okay, after I took out the -fPIC flag to get rid of the pesky warnings the library build went fine with just a couple of warnings. What's the policy when it comes to warnings? Are some warnings expected or are builds supposed to be completely clean?

Ideally, yes. We have some warnings that we know about that
we haven't cleaned up yet. They should have issues in Jira.
I don't think I've seen these, though. Could you please open
a new issue for each unique class of warnings you discover?
(For example, you can open just one issue for all the ones
below.) It would be good to also paste into the issue a link
to this thread in the archives:

http://mail-archives.apache.org/mod_mbox/incubator-stdcxx-dev/200703.mbox/%3cA647652CF20.00000B92mbrown@inbox.com%3e
(or http://tinyurl.com/2x6d4f for short, although I'm not
sure how long these tiny urls are good for).

Thanks
Martin

> 
> gcc -c -I/home/mbrown/stdcxx/include/ansi   -mthreads -D_RWSTD_USE_CONFIG -I/home/mbrown/stdcxx/include -I/home/mbrown/stdcxx-12d/include  -pedantic -nostdinc++ -O2  -W -Wall -Wcast-qual -Winline -Wshadow -Wwrite-strings -Wno-long-long -Wcast-align    /home/mbrown/stdcxx/src/collate.cpp
> /home/mbrown/stdcxx/src/collate.cpp: In member function `virtual std::basic_string<char, std::char_traits<char>, std::allocator<char> > std::collate_byname<char>::do_transform(const char*, const char*) const':
> /home/mbrown/stdcxx/src/collate.cpp:484: warning: 'pbuf' might be used uninitialized in this function
> /home/mbrown/stdcxx/src/collate.cpp: In member function `virtual std::basic_string<wchar_t, std::char_traits<wchar_t>, std::allocator<wchar_t> > std::collate_byname<wchar_t>::do_transform(const wchar_t*, const wchar_t*) const':
> /home/mbrown/stdcxx/src/collate.cpp:687: warning: 'pbuf' might be used uninitialized in this function
> 
> And also:
> 
> gcc -c -I/home/mbrown/stdcxx/include/ansi   -mthreads -D_RWSTD_USE_CONFIG -I/home/mbrown/stdcxx/include -I/home/mbrown/stdcxx-12d/include  -pedantic -nostdinc++ -O2  -W -Wall -Wcast-qual -Winline -Wshadow -Wwrite-strings -Wno-long-long -Wcast-align    /home/mbrown/stdcxx/src/iostore.cpp
> /home/mbrown/stdcxx/src/iostore.cpp: In member function `void std::ios_base::_C_copyfmt(const std::ios_base&, void*, const void*, unsigned int)':
> /home/mbrown/stdcxx/src/iostore.cpp:187: warning: 'except' might be used uninitialized in this function
> 
> 
> -- Mark