You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/03/31 12:31:44 UTC

[GitHub] [incubator-yunikorn-core] adamantal commented on a change in pull request #109: [YUNIKORN-14] Add rest API to retrieve app/container history info

adamantal commented on a change in pull request #109: [YUNIKORN-14] Add rest API to retrieve app/container history info
URL: https://github.com/apache/incubator-yunikorn-core/pull/109#discussion_r400874702
 
 

 ##########
 File path: pkg/metrics/init.go
 ##########
 @@ -54,6 +56,7 @@ type CoreSchedulerMetrics interface {
 	// Metrics Ops related to ScheduledAllocationSuccesses
 	IncAllocatedContainer()
 	AddAllocatedContainers(value int)
+	getAllocatedContainers() *prometheus.Counter
 
 Review comment:
   Makes sense, fixed

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services