You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/30 09:50:55 UTC
[GitHub] [incubator-doris] zhangstar333 opened a new pull request, #9859: [Vectorized][Function]fix to_bitmap to return always not nullable
zhangstar333 opened a new pull request, #9859:
URL: https://github.com/apache/incubator-doris/pull/9859
# Proposed changes
Issue Number: close #9715
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9859: [Vectorized][Function]fix to_bitmap to return always not nullable
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9859:
URL: https://github.com/apache/incubator-doris/pull/9859#issuecomment-1141303760
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9859: [Vectorized][Function]fix to_bitmap to return always not nullable
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9859:
URL: https://github.com/apache/incubator-doris/pull/9859#issuecomment-1144350341
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] BiteTheDDDDt commented on a diff in pull request #9859: [Vectorized][Function]fix to_bitmap to return always not nullable
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on code in PR #9859:
URL: https://github.com/apache/incubator-doris/pull/9859#discussion_r884652515
##########
be/src/vec/functions/function_bitmap.cpp:
##########
@@ -39,24 +39,47 @@ struct BitmapEmpty {
struct ToBitmap {
static constexpr auto name = "to_bitmap";
+ using ReturnType = DataTypeBitMap;
- static Status vector(const ColumnString::Chars& data, const ColumnString::Offsets& offsets,
- std::vector<BitmapValue>& res, NullMap& null_map) {
- auto size = offsets.size();
- res.reserve(size);
- for (size_t i = 0; i < size; ++i) {
- res.emplace_back();
+ static void vector(const ColumnString::Chars& data, const ColumnString::Offsets& offsets,
+ MutableColumnPtr& col_res) {
+ auto* res_column = reinterpret_cast<ColumnBitmap*>(col_res.get());
+ auto& res_data = res_column->get_data();
+ size_t size = offsets.size();
+ for (size_t i = 0; i < size; ++i) {
const char* raw_str = reinterpret_cast<const char*>(&data[offsets[i - 1]]);
size_t str_size = offsets[i] - offsets[i - 1] - 1;
StringParser::ParseResult parse_result = StringParser::PARSE_SUCCESS;
uint64_t int_value = StringParser::string_to_unsigned_int<uint64_t>(raw_str, str_size,
&parse_result);
if (LIKELY(parse_result == StringParser::PARSE_SUCCESS)) {
- res.back().add(int_value);
+ res_data[i].add(int_value);
+ }
+ }
+ }
+
+ static void vector_nullable(const ColumnString::Chars& data,
+ const ColumnString::Offsets& offsets, const NullMap& nullmap,
+ MutableColumnPtr& col_res) {
+ auto* res_column = reinterpret_cast<ColumnBitmap*>(col_res.get());
+ auto& res_data = res_column->get_data();
+ size_t size = offsets.size();
+
+ for (size_t i = 0; i < size; ++i) {
+ if (nullmap[i]) {
+ continue;
+ } else {
+ const char* raw_str = reinterpret_cast<const char*>(&data[offsets[i - 1]]);
Review Comment:
A layer of abstraction can be added here to allow the same code to be reused
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #9859: [Vectorized][Function]fix to_bitmap to return always not nullable
Posted by GitBox <gi...@apache.org>.
morningman merged PR #9859:
URL: https://github.com/apache/incubator-doris/pull/9859
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9859: [Vectorized][Function]fix to_bitmap to return always not nullable
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9859:
URL: https://github.com/apache/incubator-doris/pull/9859#issuecomment-1141303793
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] BiteTheDDDDt commented on pull request #9859: [Vectorized][Function]fix to_bitmap to return always not nullable
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on PR #9859:
URL: https://github.com/apache/incubator-doris/pull/9859#issuecomment-1141302630
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org