You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/10/25 12:10:17 UTC
[GitHub] [nifi] pvillard31 opened a new pull request #5477: NIFI-9329 - Expose event validation in ParseCEF processor
pvillard31 opened a new pull request #5477:
URL: https://github.com/apache/nifi/pull/5477
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
_Enables X functionality; fixes bug NIFI-YYYY._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] adenes merged pull request #5477: NIFI-9329 - Expose event validation in ParseCEF processor
Posted by GitBox <gi...@apache.org>.
adenes merged pull request #5477:
URL: https://github.com/apache/nifi/pull/5477
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] pvillard31 commented on a change in pull request #5477: NIFI-9329 - Expose event validation in ParseCEF processor
Posted by GitBox <gi...@apache.org>.
pvillard31 commented on a change in pull request #5477:
URL: https://github.com/apache/nifi/pull/5477#discussion_r735550647
##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ParseCEF.java
##########
@@ -144,6 +144,19 @@
.addValidator(StandardValidators.BOOLEAN_VALIDATOR)
.required(true)
.defaultValue("false")
+ .allowableValues("true", "false")
+ .build();
+
+ public static final PropertyDescriptor VALIDATE_DATA = new PropertyDescriptor.Builder()
+ .name("VALIDATE_DATA")
+ .displayName("Validate the CEF event")
+ .description("If set to true, the event will be validated against the CEF standard (revision 23). If the event is invalid, the "
+ + "FlowFile will be routed to the failure relationship. If this property is set to false, the event will be processed "
+ + "without validating the data.")
+ .addValidator(StandardValidators.BOOLEAN_VALIDATOR)
+ .required(true)
+ .defaultValue("true")
Review comment:
This is the current default. In the current processor data is validated and invalid data is sent into the failure relationship:
https://github.com/apache/nifi/blob/main/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ParseCEF.java#L250
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] adenes commented on a change in pull request #5477: NIFI-9329 - Expose event validation in ParseCEF processor
Posted by GitBox <gi...@apache.org>.
adenes commented on a change in pull request #5477:
URL: https://github.com/apache/nifi/pull/5477#discussion_r735551577
##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ParseCEF.java
##########
@@ -144,6 +144,19 @@
.addValidator(StandardValidators.BOOLEAN_VALIDATOR)
.required(true)
.defaultValue("false")
+ .allowableValues("true", "false")
+ .build();
+
+ public static final PropertyDescriptor VALIDATE_DATA = new PropertyDescriptor.Builder()
+ .name("VALIDATE_DATA")
+ .displayName("Validate the CEF event")
+ .description("If set to true, the event will be validated against the CEF standard (revision 23). If the event is invalid, the "
+ + "FlowFile will be routed to the failure relationship. If this property is set to false, the event will be processed "
+ + "without validating the data.")
+ .addValidator(StandardValidators.BOOLEAN_VALIDATOR)
+ .required(true)
+ .defaultValue("true")
Review comment:
oh, sorry, missed that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] adenes commented on a change in pull request #5477: NIFI-9329 - Expose event validation in ParseCEF processor
Posted by GitBox <gi...@apache.org>.
adenes commented on a change in pull request #5477:
URL: https://github.com/apache/nifi/pull/5477#discussion_r735543303
##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ParseCEF.java
##########
@@ -144,6 +144,19 @@
.addValidator(StandardValidators.BOOLEAN_VALIDATOR)
.required(true)
.defaultValue("false")
+ .allowableValues("true", "false")
+ .build();
+
+ public static final PropertyDescriptor VALIDATE_DATA = new PropertyDescriptor.Builder()
+ .name("VALIDATE_DATA")
+ .displayName("Validate the CEF event")
+ .description("If set to true, the event will be validated against the CEF standard (revision 23). If the event is invalid, the "
+ + "FlowFile will be routed to the failure relationship. If this property is set to false, the event will be processed "
+ + "without validating the data.")
+ .addValidator(StandardValidators.BOOLEAN_VALIDATOR)
+ .required(true)
+ .defaultValue("true")
Review comment:
this being `true` by default won't make the processor stricter, meaning input data that currently goes to success will end up in failure after this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] adenes commented on pull request #5477: NIFI-9329 - Expose event validation in ParseCEF processor
Posted by GitBox <gi...@apache.org>.
adenes commented on pull request #5477:
URL: https://github.com/apache/nifi/pull/5477#issuecomment-950881572
Thanks @pvillard31 , the change looks good to me, merging to main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org