You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "pitrou (via GitHub)" <gi...@apache.org> on 2023/05/24 11:08:40 UTC
[GitHub] [arrow] pitrou opened a new pull request, #35738: MINOR: [CI][C++] Make ASan job faster
pitrou opened a new pull request, #35738:
URL: https://github.com/apache/arrow/pull/35738
ASAN + UBSAN massively increase the generated code size.
The default compile cache size (1 GB) wasn't sufficient to hold all generated outputs, therefore the cache hit rate would be close to 0% (a cached object would be evicted before the first time it could be requested again).
Also, save 5GB in the build directory by disabling static libraries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35738: MINOR: [CI][C++] Make ASan job faster
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35738:
URL: https://github.com/apache/arrow/pull/35738#issuecomment-1569999751
['Python', 'R'] benchmarks have high level of regressions.
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/71d4e1bc06084c13908233e67e879e0b...5f4d754988614c80950cc3c470777c4c/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on pull request #35738: MINOR: [CI][C++] Make ASan job faster
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #35738:
URL: https://github.com/apache/arrow/pull/35738#issuecomment-1562153226
Very nice!
fyi you can use `--allow-empty` to trigger ci without having to do any changes (as long some changes have been made already)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #35738: MINOR: [CI][C++] Make ASan job faster
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #35738:
URL: https://github.com/apache/arrow/pull/35738#issuecomment-1560920706
cc @kou
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35738: MINOR: [CI][C++] Make ASan job faster
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35738:
URL: https://github.com/apache/arrow/pull/35738#issuecomment-1569297438
Benchmark runs are scheduled for baseline = 313fb4009c371dc42a925b3ee59bf9db53a1921a and contender = 7dce448676af91f828c004f2f570ef9599575d81. 7dce448676af91f828c004f2f570ef9599575d81 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/c6a3ea6eeb6e4d9f833f4fac464ee536...c391c3b1f8ff4f5582480b4581083f5d/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/cd410f001a2947479f22fadef4c5c59c...ad4de53f9ec94d07b4bb783337a0385e/)
[Finished :arrow_down:5.31% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/71d4e1bc06084c13908233e67e879e0b...5f4d754988614c80950cc3c470777c4c/)
[Failed :arrow_down:0.0% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/d2f4b3a5de184593a9a74d1763183160...3d2f352059f544348cb83e65fe5a06ce/)
Buildkite builds:
[Finished] [`7dce4486` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2930)
[Failed] [`7dce4486` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2966)
[Finished] [`7dce4486` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2931)
[Failed] [`7dce4486` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2956)
[Finished] [`313fb400` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2929)
[Failed] [`313fb400` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2965)
[Finished] [`313fb400` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2930)
[Failed] [`313fb400` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2955)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #35738: MINOR: [CI][C++] Make ASan job faster
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #35738:
URL: https://github.com/apache/arrow/pull/35738#issuecomment-1561075832
Example job with full caching: https://github.com/pitrou/arrow/actions/runs/5068416511/jobs/9101198018
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #35738: MINOR: [CI][C++] Make ASan job faster
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #35738:
URL: https://github.com/apache/arrow/pull/35738
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #35738: MINOR: [CI][C++] Make ASan job faster
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #35738:
URL: https://github.com/apache/arrow/pull/35738#issuecomment-1560921377
I verified that it massively improves caching on a local Docker build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org