You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "htynkn (GitHub)" <gi...@apache.org> on 2019/12/31 03:39:20 UTC

[GitHub] [dubbo] htynkn opened issue #5563: Useless null check

- [x] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
- [x] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.

### Environment

* Dubbo version: 2.7.6-snapshot

files:
https://github.com/apache/dubbo/blob/master/dubbo-rpc/dubbo-rpc-rmi/src/main/java/org/apache/dubbo/rpc/protocol/rmi/RmiProtocol.java#L91
https://github.com/apache/dubbo/blob/master/dubbo-rpc/dubbo-rpc-rmi/src/main/java/org/apache/dubbo/rpc/protocol/rmi/RmiProtocol.java#L99

This check is useless, invocation cannot be null here, since new RmiRemoteInvocation(...) always is non-null.



[ Full content available at: https://github.com/apache/dubbo/issues/5563 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org


[GitHub] [dubbo] lzf971107 commented on issue #5563: Useless null check

Posted by "lzf971107 (GitHub)" <gi...@apache.org>.
Can i help you solve this

[ Full content available at: https://github.com/apache/dubbo/issues/5563 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org