You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by cloverhearts <gi...@git.apache.org> on 2016/07/22 11:47:10 UTC
[GitHub] zeppelin pull request #1218: [Zeppelin-1213] Code Editor Configuration Perso...
GitHub user cloverhearts opened a pull request:
https://github.com/apache/zeppelin/pull/1218
[Zeppelin-1213] Code Editor Configuration Personalization
### What is this PR for?
Code Editor Configuration Personalization
each user can apply to code editor setting.
for example, editor theme, indent, font size, editor print margin...
You can re-set for each interpreter tag.
(E.g %spark -> font size, indent, theme)
### What type of PR is it?
Feature
### Todos
- [x] create to editor configuration setting page.
- [x] added to theme
- [x] added support language
- [x] change to font size and indent theme
- [x] editor config serialize / deserialize
- [x] preview window.
- [x] create and delete, and save.
- [x] add web socket event for code editor setting.
- [x] apply to setting for user custom interpreter tag
- [x] if exists paragraph setting then priority set paragaraph setting (show line number setting)
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1213
### How should this be tested?
1. click to user name menu in navbar and click to Editor Configuration menu.
1. set up editor setting. (and using preview pargraph)
1. click to save button.
1. move to any paragraph.
1. check to apply setting.
1. check to exists conf/code-editor.json in zeppelin directory.
### Screenshots (if appropriate)
<img width="1274" alt="setup" src="https://cloud.githubusercontent.com/assets/10525473/17056055/e56c1236-504b-11e6-803f-4223c813c99e.png">
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/zeppelin ZEPPELIN-1213
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1218.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1218
----
commit d351f747e06994185a92c34fc63e76b007fa537c
Author: CloverHearts <cl...@gmail.com>
Date: 2016-07-22T10:50:35Z
Implement Backend for code editor configuration
commit ef09a05447467cff594b593111b8e68ff628fa81
Author: CloverHearts <cl...@gmail.com>
Date: 2016-07-22T11:00:17Z
Implement frontend for code editor setting
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1218: [Zeppelin-1213] Customize editor configuration
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1218
@bzz @corneadoug
Okay, Thank you very much
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1218: [Zeppelin-1213] Customize editor configuration
Posted by hyonaldo <gi...@git.apache.org>.
Github user hyonaldo commented on the issue:
https://github.com/apache/zeppelin/pull/1218
How can I use this feature?
Though I've installed latest build version, I could not find "Editor Configuration menu" anywhere.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1218: [Zeppelin-1213] Customize editor configuration
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1218
This PR is way too big to be reviewed properly.
I'm not sure every settings are necessary (especially from the start).
And I also have issues with the fact that every Theme from Ace is included.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1218: [Zeppelin-1213] Customize editor configuration
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1218
@cloverhearts Really great feature! I can't wait to build and run this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1218: [Zeppelin-1213] Customize editor configuration
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1218
Thank you for feedback @corneadoug .
I can possible divide to this pr.
and I have a question.
```
I also have issues with the fact that every Theme from Ace is included.
```
Can you give me an explanation why that is a problem?
If you have a problem, I need to clear a part of the theme changes.
a very easy fix.
I thought that people would want to coding in a theme familiar to them.
Once again thank you for your message.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1218: [Zeppelin-1213] Customize editor configuration
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1218
@cloverhearts Don't hesitate to ping me when you start making the small PRs
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1218: [Zeppelin-1213] Customize editor configuration
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1218
@cloverhearts it would be nice to divide it in multiple PRs and commits.
For the theme, I'm not against them wanting to change it, however in this case crowding the build by importing all the Ace theme inside the build, even though 70% of them will probably not be used.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1218: [Zeppelin-1213] Customize editor configuration
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1218
Shall we close this one now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1218: [Zeppelin-1213] Customize editor configuration
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1218
@bzz i am sorry to late for response.
The PR was divided.
https://github.com/apache/zeppelin/pull/1256
and jira issue subtask
https://issues.apache.org/jira/browse/ZEPPELIN-1213
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1218: [Zeppelin-1213] Customize editor configuration
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1218
@bzz Okay!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1218: [Zeppelin-1213] Customize editor configuration
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1218
I removed the feature to change the theme.
It will also split into a new PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1218: [Zeppelin-1213] Customize editor configuration
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1218
@cloverhearts ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1218: [Zeppelin-1213] Customize editor configuration
Posted by raulgomis <gi...@git.apache.org>.
Github user raulgomis commented on the issue:
https://github.com/apache/zeppelin/pull/1218
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1218: [Zeppelin-1213] Customize editor configuration
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1218
I agree with @corneadoug that this is a big change to review.
One more thing - @cloverhearts can you please add some tests for this feature?
See `AuthenticationIT.java` for an example of Integration Test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1218: [Zeppelin-1213] Customize editor configuration
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1218
@hyonaldo
Sorry,
We can not support this feature on zeppelin.
I do not care for this feature into master.
It also differs from the current source in many ways.
Re-implementation is required.
I have no plans to reimplement this until now.
Perhaps, if you want this feature.
You can create an issue in our jira. (https://issues.apache.org/jira/browse/ZEPPELIN)
Sorry, again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1218: [Zeppelin-1213] Customize editor configuration
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1218
That looks great! Thank you @cloverhearts let's close this PR then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1218: [Zeppelin-1213] Customize editor configuration
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts closed the pull request at:
https://github.com/apache/zeppelin/pull/1218
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---