You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/13 16:27:20 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #3823: Minor: Sort the output of SHOW ALL by config name
alamb opened a new pull request, #3823:
URL: https://github.com/apache/arrow-datafusion/pull/3823
# Rationale for this change
Noticed while working on https://github.com/apache/arrow-datafusion/pull/3822
The `show all` command added by @waitingkuo in https://github.com/apache/arrow-datafusion/pull/3455 is awesome!
When I do `show all` I am trying to verify the setting of a particular configuration option. As coded now, the output comes out in some random order (hash value I suspect):
Before:
```shell
❯ show all;
+-------------------------------------------------+---------+
| name | setting |
+-------------------------------------------------+---------+
| datafusion.execution.coalesce_target_batch_size | 4096 |
| datafusion.optimizer.filter_null_join_keys | false |
| datafusion.explain.physical_plan_only | false |
| datafusion.explain.logical_plan_only | false |
| datafusion.execution.coalesce_batches | true |
| datafusion.execution.batch_size | 8192 |
| datafusion.optimizer.skip_failed_rules | true |
| datafusion.execution.time_zone | UTC |
+-------------------------------------------------+---------+
11 rows in set. Query took 0.005 seconds.
```
After:
```shell
❯ show all;
+-------------------------------------------------+---------+
| name | setting |
+-------------------------------------------------+---------+
| datafusion.execution.batch_size | 8192 |
| datafusion.execution.coalesce_batches | true |
| datafusion.execution.coalesce_target_batch_size | 4096 |
| datafusion.execution.time_zone | UTC |
| datafusion.explain.logical_plan_only | false |
| datafusion.explain.physical_plan_only | false |
| datafusion.optimizer.filter_null_join_keys | false |
| datafusion.optimizer.skip_failed_rules | true |
+-------------------------------------------------+---------+
```
# What changes are included in this PR?
Add `ORDER BY` clause and test
# Are there any user-facing changes?
More helpful visibility into config options
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove merged pull request #3823: Minor: Sort the output of SHOW ALL by config name
Posted by GitBox <gi...@apache.org>.
andygrove merged PR #3823:
URL: https://github.com/apache/arrow-datafusion/pull/3823
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #3823: Minor: Sort the output of SHOW ALL by config name
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3823:
URL: https://github.com/apache/arrow-datafusion/pull/3823#issuecomment-1279053210
Benchmark runs are scheduled for baseline = 87dd4ff605110cfc491f8022798f226d257bcce4 and contender = aa0ded74b5bbe5fac7e5922cff1a1a0c5895b43e. aa0ded74b5bbe5fac7e5922cff1a1a0c5895b43e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/6b8e689483674c12b561501338fcd7e4...65d33acd2f1d4712a4c43507a64847f6/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/b2601a6895f74f58a03f8e925e3b0ed4...5e7d20d9a3744f5cbb00289a474efe36/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/43259c9cedf24062a801404c1b0aa1bd...f6f32bfcb7b34d5b9a22e036282899ea/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/1642599316564c9599df0508e1b1acbb...a832ed22ae1a4e33ab62902239f7b998/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org