[GitHub] [incubator-nemo] taegeonum commented on a change in pull request #318: [NEMO-472] Implement Intermediate Combine

[GitBox <gi...@apache.org>]

taegeonum commented on a change in pull request #318:
URL: https://github.com/apache/incubator-nemo/pull/318#discussion_r697936287



##########
File path: common/src/main/java/org/apache/nemo/common/ir/IRDAGChecker.java
##########
@@ -486,6 +489,28 @@ void addEncodingCompressionCheckers() {
     singleEdgeCheckerList.add(compressAndDecompress);
   }
 
+  void addIntermediateAccumulatorVertexCheckers() {
+    final NeighborChecker shuffleExecutorSet = ((v, inEdges, outEdges) -> {
+      if (v.getPropertyValue(ShuffleExecutorSetProperty.class).isPresent()) {
+        if (inEdges.size() != 1 || outEdges.size() != 1 || inEdges.stream().anyMatch(e ->
+          !e.getPropertyValue(CommunicationPatternProperty.class).get()
+            .equals(CommunicationPatternProperty.Value.PARTIAL_SHUFFLE))) {
+          return failure("Only intermediate accumulator vertex can have shuffle executor set property", v);

Review comment:
       Isn't `v` is intermediate accumulator vertex? 
   Or the comment should be `An intermediate accumulator vertex can only have shuffle executor set property`? 

##########
File path: compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/transform/CombineTransform.java
##########
@@ -45,9 +45,9 @@
  * @param <InputT> input type
  * @param <OutputT> output type
  */
-public final class GBKTransform<K, InputT, OutputT>
+public final class CombineTransform<K, InputT, OutputT>

Review comment:
       Could you explain why the class name is changed? 

##########
File path: common/src/main/java/org/apache/nemo/common/ir/IRDAGChecker.java
##########
@@ -486,6 +489,28 @@ void addEncodingCompressionCheckers() {
     singleEdgeCheckerList.add(compressAndDecompress);
   }
 
+  void addIntermediateAccumulatorVertexCheckers() {
+    final NeighborChecker shuffleExecutorSet = ((v, inEdges, outEdges) -> {
+      if (v.getPropertyValue(ShuffleExecutorSetProperty.class).isPresent()) {

Review comment:
       We can filter accumulator vertex by `v` instanceof `PartialAccumulatorVertex` if we create `PartialAccumulatorVertex` 

##########
File path: common/src/main/java/org/apache/nemo/common/ir/vertex/executionproperty/ShuffleExecutorSetProperty.java
##########
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.nemo.common.ir.vertex.executionproperty;
+
+import org.apache.nemo.common.ir.executionproperty.VertexExecutionProperty;
+
+import java.util.ArrayList;
+import java.util.HashSet;
+
+/**
+ * List of set of node names to limit the scheduling of the tasks of the vertex to while shuffling.
+ */
+public final class ShuffleExecutorSetProperty extends VertexExecutionProperty<ArrayList<HashSet<String>>> {

Review comment:
       Is this only for paritial accumulator vertex? then please add some comments. 
   `PartialShuffleDestinationExecutorSetProperty`? 

##########
File path: common/src/main/java/org/apache/nemo/common/ir/IRDAG.java
##########
@@ -799,6 +800,39 @@ public void insert(final TaskSizeSplitterVertex toInsert) {
     modifiedDAG = builder.build();
   }
 
+  public void insert(final OperatorVertex accumulatorVertex, final IREdge targetEdge) {

Review comment:
       How about creating a new class `PartialAccumulatorVertex` that inherits `OperatorVertex`? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@nemo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org