You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/07/30 17:34:34 UTC

[GitHub] [incubator-mxnet] mseth10 commented on pull request #18779: [WIP] Support extra inputs for subgraph ops

mseth10 commented on pull request #18779:
URL: https://github.com/apache/incubator-mxnet/pull/18779#issuecomment-666549341


   > @mseth10 @rondogency should we change `supportedOps` to use the `Graph` class too instead of passing the JSON string like:
   > 
   > ```
   > MXReturnValue mySupportedOps(const Graph& g,
   >                              std::vector<int>* ids,
   >                              const std::unordered_map<std::string, std::string>& options)
   > ```
   
   Would we need to provide users with a Graph parser then, just like we provide a JsonParser currently?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org