You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "zeroshade (via GitHub)" <gi...@apache.org> on 2023/06/14 15:16:21 UTC
[GitHub] [arrow] zeroshade opened a new pull request, #36066: GH-36052: [Go][Parquet] Cross build failures for 386
zeroshade opened a new pull request, #36066:
URL: https://github.com/apache/arrow/pull/36066
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
Fixing building the Go Parquet library for GOARCH=386
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
### What changes are included in this PR?
Simplify and clean up build tags and specialized asm in Go Parquet library so that we don't need to keep adding new files explicitly for architectures that we didn't generate optimized assembly for. So we set up the appropriate defaults so that those architectures will default to the pure go implementation properly.
Also fixes the usage of `math.Uint32` so that it isn't seen as an untyped int constant which would overflow on 32-bit architectures.
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
### Are these changes tested?
Yes, added a small workflow that builds the Go arrow and parquet libraries with `GOARCH=386`.
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #36066: GH-36052: [Go][Parquet] Cross build failures for 386
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36066:
URL: https://github.com/apache/arrow/pull/36066#issuecomment-1591451073
:warning: GitHub issue #36052 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #36066: GH-36052: [Go][Parquet] Cross build failures for 386
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #36066:
URL: https://github.com/apache/arrow/pull/36066#issuecomment-1591452215
@ShourieG can you try using this PR with your build and confirming that it works?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade merged pull request #36066: GH-36052: [Go][Parquet] Cross build failures for 386
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #36066:
URL: https://github.com/apache/arrow/pull/36066
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ShourieG commented on pull request #36066: GH-36052: [Go][Parquet] Cross build failures for 386
Posted by "ShourieG (via GitHub)" <gi...@apache.org>.
ShourieG commented on PR #36066:
URL: https://github.com/apache/arrow/pull/36066#issuecomment-1592728326
> @ShourieG can you try using this PR with your build and confirming that it works?
@zeroshade the PR has resolved the crossBuild errors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] conbench-apache-arrow[bot] commented on pull request #36066: GH-36052: [Go][Parquet] Cross build failures for 386
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #36066:
URL: https://github.com/apache/arrow/pull/36066#issuecomment-1594957811
Conbench analyzed the 6 benchmark runs on commit `4a537645`.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/14328121362) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ShourieG commented on pull request #36066: GH-36052: [Go][Parquet] Cross build failures for 386
Posted by "ShourieG (via GitHub)" <gi...@apache.org>.
ShourieG commented on PR #36066:
URL: https://github.com/apache/arrow/pull/36066#issuecomment-1592556034
@zeroshade wanted to try this out but I'm having difficulties in upgrading the library to point to this commit as we use the pqarrow library and I'm constantly getting the error:
```js
github.com/apache/arrow/go/parquet/pqarrow: module github.com/apache/arrow/go/parquet@latest found (v0.0.0-20211112161151-bc219186db40), but does not contain package github.com/apache/arrow/go/parquet/pqarrow
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org