You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/10/09 15:04:37 UTC

[GitHub] [iceberg] RussellSpitzer commented on a change in pull request #1569: API: add some validation when create bucket/truncate partition

RussellSpitzer commented on a change in pull request #1569:
URL: https://github.com/apache/iceberg/pull/1569#discussion_r502493448



##########
File path: api/src/main/java/org/apache/iceberg/transforms/Bucket.java
##########
@@ -44,6 +45,9 @@
 
   @SuppressWarnings("unchecked")
   static <T> Bucket<T> get(Type type, int numBuckets) {
+    Preconditions.checkArgument(numBuckets > 0,
+        "The number of bucket must larger than zero,but is %s", numBuckets);

Review comment:
       nits: Missing a space after the comma
   number of bucket(s)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org