You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/06/14 13:01:34 UTC

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #874: session management draft

korlov42 commented on code in PR #874:
URL: https://github.com/apache/ignite-3/pull/874#discussion_r896788680


##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/api/SessionBuilderImpl.java:
##########
@@ -103,20 +106,32 @@ public SessionBuilder defaultPageSize(int pageSize) {
     /** {@inheritDoc} */
     @Override
     public SessionBuilder property(String name, @Nullable Object value) {
-        props.put(name, value);
+        var prop = QueryProperty.byName(name);

Review Comment:
   This is a sessionBuilder for embedded session, so the set of properties will always be the same.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org