[jira] [Commented] (HADOOP-10269) SaslException is completely ignored

["Daryn Sharp (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-10269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13880042#comment-13880042 ] 

Daryn Sharp commented on HADOOP-10269:
--------------------------------------

If the sasl wrapping fails then it really doesn't matter if disposing of the sasl object fails.  Disposing shouldn't fail because it's clearing internal state but even if it does it's likely related to the wrap failure.  The original/rethrown exception from the wrap failure is what really matters.

If that makes sense, I think this jira should be marked invalid.

> SaslException is completely ignored
> -----------------------------------
>
>                 Key: HADOOP-10269
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10269
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 2.2.0
>            Reporter: Ding Yuan
>
> In "org/apache/hadoop/security/SaslOutputStream.java", there is the following code pattern:
> {noformat}
> 172    try {
> 173      if (saslServer != null) { // using saslServer
> 174        saslToken = saslServer.wrap(inBuf, off, len);
> 175      } else { // using saslClient
> 176        saslToken = saslClient.wrap(inBuf, off, len);
> 177      }
> 178    } catch (SaslException se) {
> 179      try {
> 180       disposeSasl();
> 181      } catch (SaslException ignored) {
> 182      }
> 183      throw se;
> 184    }
> {noformat}
> On line 181, the exception thrown by disposeSasl(), which can be from SaslServer.dispose() or SaslClient.dispose(), is ignored completely without even logging it. Maybe at least log it?
> Ding



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)