You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Jens Geyer (JIRA)" <ji...@apache.org> on 2015/05/10 17:21:00 UTC

[jira] [Comment Edited] (THRIFT-3138) "make check" parallel execution is underministic

    [ https://issues.apache.org/jira/browse/THRIFT-3138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14537222#comment-14537222 ] 

Jens Geyer edited comment on THRIFT-3138 at 5/10/15 3:20 PM:
-------------------------------------------------------------

I can confirm this, I already filed a bunch of other tickets related to that. Some of the test code is prone to race conditions big time. Set up a slow machine or VM and you will run into all kinds of troubles with {{make check}}.


was (Author: jensg):
I can confirm this, I already filed a bunch of other tickets related to that. Some of the test code is prone to race conditions big time. Set up a slow machine or VM and you will run in all kinds of troubles with {{make check}}.

> "make check" parallel execution is underministic
> ------------------------------------------------
>
>                 Key: THRIFT-3138
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3138
>             Project: Thrift
>          Issue Type: Bug
>          Components: Build Process, C glib - Library, Go - Library, Python - Library
>            Reporter: Nobuaki Sukegawa
>            Priority: Minor
>
> Some {{make}} tasks dependent on generated Thrift code occasionally fail.
> THRIFT-2971 fixed it for cpp but some languages' {{make check}} still have the problem, namely,
> c_glib, go and python.
> Command I used to reproduce the behavior locally:
> {code}
> git clean -dfx && ./bootstrap.sh && ./configure --without-... && make check -j24
> {code}
> It only fails occasionally and the failure location varies.
> An example of build failure log in case of c_glib:
> {code}
> gen-c_glib/t_test_inherited.h:37:3: error: unknown type name ‘TTestSrvClient’
>    TTestSrvClient parent;
>    ^
> gen-c_glib/t_test_inherited.h:43:3: error: unknown type name ‘TTestSrvClientClass’
>    TTestSrvClientClass parent;
>    ^
> gen-c_glib/t_test_inherited.h:64:3: error: unknown type name ‘TTestSrvHandler’
>    TTestSrvHandler parent;
>    ^
> gen-c_glib/t_test_inherited.h:70:3: error: unknown type name ‘TTestSrvHandlerClass’
>    TTestSrvHandlerClass parent;
>    ^
> gen-c_glib/t_test_inherited.h:89:3: error: unknown type name ‘TTestSrvProcessor’
>    TTestSrvProcessor parent;
>    ^
> gen-c_glib/t_test_inherited.h:99:3: error: unknown type name ‘TTestSrvProcessorClass’
>    TTestSrvProcessorClass parent;
>    ^
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)