You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2015/09/01 12:21:41 UTC
Re: Review Request 37935: HIVE-11482: Add retrying thrift client for
HiveServer2
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37935/#review97272
-----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (line 2026)
<https://reviews.apache.org/r/37935/#comment153106>
Change description as "Number of retries upon failure of Thrift HiveServer2 calls"
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (line 2028)
<https://reviews.apache.org/r/37935/#comment153105>
Change description as " Number of retries while opening a connection to HiveServe2"
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (line 2029)
<https://reviews.apache.org/r/37935/#comment153107>
Specify a TimeValidator similar to param METASTORE_CLIENT_CONNECT_RETRY_DELAY.
Also, change description to "Number of seconds for the HiveServer2 thrift client to wait between consecutive connection attempts; also specifies the time to wait between retrying thrift calls upon failures"
- Amareshwari Sriramadasu
On Aug. 30, 2015, 8:48 p.m., Akshay Goyal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37935/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2015, 8:48 p.m.)
>
>
> Review request for hive and Amareshwari Sriramadasu.
>
>
> Bugs: HIVE-11482
> https://issues.apache.org/jira/browse/HIVE-11482
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Similar to RetryingMetaStoreClient, this improvement request is to add a retrying thrift client for HiveServer2 to do retries in case of thrift exceptions.
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 8a00079631b657acd79877202e9819ff282dfdd6
> service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java PRE-CREATION
> service/src/test/org/apache/hive/service/cli/TestRetryingThriftCLIServiceClient.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37935/diff/
>
>
> Testing
> -------
>
> Added test case TestRetryingThriftCLIServiceClient to check whether retries are happening in case of exceptions and also whether connections are going through if everything is fine.
>
>
> Thanks,
>
> Akshay Goyal
>
>