You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/25 20:28:12 UTC
[GitHub] [airflow] ryw opened a new issue #10560: new API takes over /airflow/api
ryw opened a new issue #10560:
URL: https://github.com/apache/airflow/issues/10560
for 2.0, should we should change the path of `/api_connexion` to `/api` and `/api` to `/api_deprecated`?
Any reason not to do that now in master branch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #10560: New API takes over /airflow/api
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #10560:
URL: https://github.com/apache/airflow/issues/10560#issuecomment-680270653
It's about our deprecation rules. If it's not absolutely necessary the rule is that we have at least one release when we deprecate something before we remove.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #10560: New API takes over /airflow/api
Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #10560:
URL: https://github.com/apache/airflow/issues/10560#issuecomment-981961725
I think there are no further tasks on this issue
can be closed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryw commented on issue #10560: New API takes over /airflow/api
Posted by GitBox <gi...@apache.org>.
ryw commented on issue #10560:
URL: https://github.com/apache/airflow/issues/10560#issuecomment-680320321
i was referencing source code structure - sorry that wasn't clear
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed issue #10560: New API takes over /airflow/api
Posted by GitBox <gi...@apache.org>.
potiuk closed issue #10560:
URL: https://github.com/apache/airflow/issues/10560
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryw edited a comment on issue #10560: New API takes over /airflow/api
Posted by GitBox <gi...@apache.org>.
ryw edited a comment on issue #10560:
URL: https://github.com/apache/airflow/issues/10560#issuecomment-682097230
thanks for the detail @mik-laj - makes more sense.
if its possible, I think it'd be nice if all the code that we're keeping is moved into the `/airflow/api` directory and all the code that we're deprecating gets moved to `/airflow/api_deprecated` directory so it's easier to reason about the stable API - and read code related to it.
but if this would be painful to execute on, we can just close this issue :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #10560: New API takes over /airflow/api
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #10560:
URL: https://github.com/apache/airflow/issues/10560#issuecomment-680271712
I actually proposed to deprecate the old API in 1.10.12 but the majority vote was that we should not deprecate something unless we provide a replacement - which makes perfect sense as it does not allow you to do the sequence:
1) migrate first
2) change your way of doing things
3) migrate again
It requires you to migrate and change at the same time which is super-risky.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on issue #10560: New API takes over /airflow/api
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #10560:
URL: https://github.com/apache/airflow/issues/10560#issuecomment-680317639
@ryw Moving the API to a different path is a change that breaks all existing integrations. Most of them have a fixed path, and it's not easy to change. Some users won't even be able to change it easily as they have a heterogeneous environment with different Airflow versions.
If you want to check if the API is deprecated, you can send a request via CURL and look at the headers.
See: https://github.com/apache/airflow/pull/9888
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on issue #10560: New API takes over /airflow/api
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #10560:
URL: https://github.com/apache/airflow/issues/10560#issuecomment-680319524
Have you been talking about package structure or URLs? This is not clear from your ticket.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj edited a comment on issue #10560: New API takes over /airflow/api
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on issue #10560:
URL: https://github.com/apache/airflow/issues/10560#issuecomment-680325218
This here is a more complicated matter as some packages are deprecated and some will not.
**airflow.api.auth**
it's not deprecated. We use it in Stable API also.
**airflow.api.client**
This is still under discussion. We don't have a conclusion about it. For now, @ash has suggested that this package should stay until we have a detailed vision of CLI development. So we should keep it backward compatible.
https://lists.apache.org/thread.html/rfada8ac2fce87c0516d62923e35e3bebfc44ee5a379103b890f8c61c%40%3Cdev.airflow.apache.org%3E
@houqp working on alternative python client: https://github.com/apache/airflow-client-python https://github.com/apache/airflow/issues/9080
**airflow.api.common.experimental**
This is a surprise, but these are not the endpoints for the experimental API. This package is also widely used in core and web UI and airflow.api.client This is another utils package.
**airflow.api_connexion**
Everything related to a stable API.
**airflow.www.api.experimental.endpoints**
Endpoint for experimental API. This package will be deleted in Airflow 2.1 when we delete the experimental API only. The rest of the packages should be backward compatible according to ongoing discussions as we have no decision to drop them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on issue #10560: New API takes over /airflow/api
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #10560:
URL: https://github.com/apache/airflow/issues/10560#issuecomment-680325218
This here is a more complicated matter as some packages are deprecated and some will not.
**airflow.api.auth**
it's not deprecated. We use it in Stable API also.
**airflow.api.client**
This is still under discussion. We don't have a conclusion about it. For now, @ash has suggested that this package should stay until we have a detailed vision of CLI development. So we should keep it backward compatible.
https://lists.apache.org/thread.html/rfada8ac2fce87c0516d62923e35e3bebfc44ee5a379103b890f8c61c%40%3Cdev.airflow.apache.org%3E
@houqp working on alternative python client: https://github.com/apache/airflow-client-python https://github.com/apache/airflow/issues/9080
**airflow.api.common.experimental**
This is a surprise, but these are not the endpoints for the experimental API. This package is also widely used in core and web UI. This is another utils package.
**airflow.api_connexion**
Everything related to a stable API.
**airflow.www.api.experimental.endpoints**
Endpoint for experimental API. This package will be deleted in Airflow 2.1 when we delete the experimental API only. The rest of the packages should be backward compatible according to ongoing discussions as we have no decision to delete them. The rest of the packages should be backwards compatible as we have no decision to delete or drop them
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryw closed issue #10560: New API takes over /airflow/api
Posted by GitBox <gi...@apache.org>.
ryw closed issue #10560:
URL: https://github.com/apache/airflow/issues/10560
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryw commented on issue #10560: New API takes over /airflow/api
Posted by GitBox <gi...@apache.org>.
ryw commented on issue #10560:
URL: https://github.com/apache/airflow/issues/10560#issuecomment-680318201
Ok makes sense - didn't know how routes get rendered, but if it's reading from file structure then I'm ok to keep it as it is for now. Closing issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryw commented on issue #10560: New API takes over /airflow/api
Posted by GitBox <gi...@apache.org>.
ryw commented on issue #10560:
URL: https://github.com/apache/airflow/issues/10560#issuecomment-682097230
thanks for the detail @mik-laj - makes more sense.
if its possible, I think it'd be nice if all the code that we're keeping is moved into the `/airflow/api` directory and all the code that we're deprecating gets moved to `/airflow/api_deprecated` directory so it's easier to reason about the stable API - and read code related to it.
but if this would be painful in any way, we can just close this issue :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj edited a comment on issue #10560: New API takes over /airflow/api
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on issue #10560:
URL: https://github.com/apache/airflow/issues/10560#issuecomment-680325218
This here is a more complicated matter as some packages are deprecated and some will not.
**airflow.api.auth**
it's not deprecated. We use it in Stable API also.
**airflow.api.client**
This is still under discussion. We don't have a conclusion about it. For now, @ash has suggested that this package should stay until we have a detailed vision of CLI development. So we should keep it backward compatible.
https://lists.apache.org/thread.html/rfada8ac2fce87c0516d62923e35e3bebfc44ee5a379103b890f8c61c%40%3Cdev.airflow.apache.org%3E
@houqp working on alternative python client: https://github.com/apache/airflow-client-python https://github.com/apache/airflow/issues/9080
**airflow.api.common.experimental**
This is a surprise, but these are not the endpoints for the experimental API. This package is also widely used in core and web UI and airflow.api.client This is another utils package.
**airflow.api_connexion**
Everything related to a stable API.
**airflow.www.api.experimental.endpoints**
Endpoint for experimental API. This package will be deleted in Airflow 2.1 when we delete the experimental API only. The rest of the packages should be backward compatible according to ongoing discussions as we have no decision to delete them. The rest of the packages should be backwards compatible as we have no decision to delete or drop them
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryw commented on issue #10560: New API takes over /airflow/api
Posted by GitBox <gi...@apache.org>.
ryw commented on issue #10560:
URL: https://github.com/apache/airflow/issues/10560#issuecomment-680277895
I'm not suggesting we remove the old api, just give it a different code path - and give /api directory to the new API -- took me a minute today to figure out which one was the new API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org