You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Amogh Vasekar <am...@citrix.com> on 2013/07/30 02:38:12 UTC
Review Request 13047: VMSnapshot chainSize check
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13047/
-----------------------------------------------------------
Review request for cloudstack and mice xia.
Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3591
Repository: cloudstack-git
Description
-------
Add check to ensure chainSize adds memory size to ROOT volume only when VMSnapshot Type is DiskAndMemory
Diffs
-----
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java 10b6de9
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java fa7f2ec
Diff: https://reviews.apache.org/r/13047/diff/
Testing
-------
Local environment
Thanks,
Amogh Vasekar
Re: Review Request 13047: VMSnapshot chainSize check
Posted by mice xia <mi...@tcloudcomputing.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13047/#review24200
-----------------------------------------------------------
the chainSize for a volume is the total size of all nodes, not a single snapshot volume size, so no matter current snapshot is memoryDisk or Disk, all memory image associated with this vm should be considered
- mice xia
On July 30, 2013, 12:38 a.m., Amogh Vasekar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13047/
> -----------------------------------------------------------
>
> (Updated July 30, 2013, 12:38 a.m.)
>
>
> Review request for cloudstack and mice xia.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3591
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Add check to ensure chainSize adds memory size to ROOT volume only when VMSnapshot Type is DiskAndMemory
>
>
> Diffs
> -----
>
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java 10b6de9
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java fa7f2ec
>
> Diff: https://reviews.apache.org/r/13047/diff/
>
>
> Testing
> -------
>
> Local environment
>
>
> Thanks,
>
> Amogh Vasekar
>
>
Re: Review Request 13047: VMSnapshot chainSize check
Posted by "Jenkins Cloudstack.org" <hu...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13047/#review24186
-----------------------------------------------------------
Review 13047 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #77 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/77/
- Jenkins Cloudstack.org
On July 30, 2013, 12:38 a.m., Amogh Vasekar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13047/
> -----------------------------------------------------------
>
> (Updated July 30, 2013, 12:38 a.m.)
>
>
> Review request for cloudstack and mice xia.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3591
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Add check to ensure chainSize adds memory size to ROOT volume only when VMSnapshot Type is DiskAndMemory
>
>
> Diffs
> -----
>
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java 10b6de9
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java fa7f2ec
>
> Diff: https://reviews.apache.org/r/13047/diff/
>
>
> Testing
> -------
>
> Local environment
>
>
> Thanks,
>
> Amogh Vasekar
>
>