DO NOT REPLY [Bug 49066] [PATCH] worksheet/cell formatting, with view and HTML converter

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=49066

Yegor Kozlov <ye...@dinom.ru> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #1 from Yegor Kozlov <ye...@dinom.ru> 2010-05-10 12:14:30 EDT ---
Thanks for the excellent patch. Sorry it took so long to review and apply.

I committed it in r942809 with some tweaks:

 (1) The poi-contrib module is obsolete. Eventually, all its contents will be
repackaged and the module itself will be zapped. 

 I put org.apache.poi.ss.format.* in poi-main, it is a general-purpose code
that can be re-used across POI. ToHtml and SViewer were moved to poi-examples. 

 (2) SVSheetTable#setupScroll(JScrollPane scroll) did not compile. The problem
line was 
    SVRowHeader rowHeader = new SVRowHeader(sheet, this);

The constructor of SVRowHeader takes 3 arguments and I changed it to 

    SVRowHeader rowHeader = new SVRowHeader(sheet, this, 0);

Please confirm that it makes sense.

 (3) I added the Apache Licence Header to almost all new classes. ASF header is
a must. 

 (4) org.apache.poi.ss.format.CellNumberFormatter depends on a class from
Apache Commons-Math. I would rather avoid dependency on the Commons-Math jar
and created an inner class CellNumberFormatter.Fraction based on
org.apache.commons.math.fraction.Fraction. When POI uses more classes from
Commons-Math then I'm OK to drop this inner class and use Commons-Math, but for
a single dependency and I would rather duplicate code. 

 (5) The preferred way of constructing Workbook from the given InputStream is
to use WorkbookFactory.create(InputStream in). I changed ToHtml to use
WorkbookFactory and removed ToHtml#createXSSF and ToHtml#createHSSF. 

 (6) By convention, names of test classes start with Test*, the build script
runs junit only for files matching "**/Test*.java" . I renamed classes in
org.apache.poi.ss.format.* to follow this convention.

Other than that, very cool! Thanks again.  

Regards,
Yegor

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org