You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by venkat sairam <ve...@gmail.com> on 2017/01/02 13:06:43 UTC

Review Request 55120: Issue with FS action node in oozie workflow designer

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55120/
-----------------------------------------------------------

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Renjith Kamath.


Bugs: AMBARI-19332
    https://issues.apache.org/jira/browse/AMBARI-19332


Repository: ambari


Description
-------

There is an issue with the way object is saved.We have changed the object structure and made all relevant changes for saving and importing.


Diffs
-----

  contrib/views/wfmanager/src/main/resources/ui/app/components/fs-action.js 03acbf3 
  contrib/views/wfmanager/src/main/resources/ui/app/components/prepare-config-fs.js 3c425d9 
  contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js 2ce0ab4 
  contrib/views/wfmanager/src/main/resources/ui/app/templates/components/prepare-config-fs.hbs c549a26 
  contrib/views/wfmanager/src/main/resources/ui/app/validators/fs-action-validator.js 4064379 

Diff: https://reviews.apache.org/r/55120/diff/


Testing
-------

We have created workflow with FS action editor, Saved it and imported it into WFD and tested the functionality.


Thanks,

venkat sairam


Re: Review Request 55120: Issue with FS action node in oozie workflow designer

Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55120/#review160337
-----------------------------------------------------------


Ship it!




Ship It!

- Pallav Kulshreshtha


On Jan. 2, 2017, 1:41 p.m., venkat sairam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55120/
> -----------------------------------------------------------
> 
> (Updated Jan. 2, 2017, 1:41 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Renjith Kamath.
> 
> 
> Bugs: AMBARI-19332
>     https://issues.apache.org/jira/browse/AMBARI-19332
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> There is an issue with the way object is saved.We have changed the object structure and made all relevant changes for saving and importing.
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/fs-action.js 03acbf3 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/prepare-config-fs.js 3c425d9 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js 2ce0ab4 
>   contrib/views/wfmanager/src/main/resources/ui/app/templates/components/prepare-config-fs.hbs c549a26 
>   contrib/views/wfmanager/src/main/resources/ui/app/validators/fs-action-validator.js 4064379 
> 
> Diff: https://reviews.apache.org/r/55120/diff/
> 
> 
> Testing
> -------
> 
> We have created workflow with FS action editor, Saved it and imported it into WFD and tested the functionality.
> 
> 
> Thanks,
> 
> venkat sairam
> 
>


Re: Review Request 55120: Issue with FS action node in oozie workflow designer

Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55120/#review160322
-----------------------------------------------------------


Ship it!




Ship It!

- Gaurav Nagar


On Jan. 2, 2017, 1:41 p.m., venkat sairam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55120/
> -----------------------------------------------------------
> 
> (Updated Jan. 2, 2017, 1:41 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Renjith Kamath.
> 
> 
> Bugs: AMBARI-19332
>     https://issues.apache.org/jira/browse/AMBARI-19332
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> There is an issue with the way object is saved.We have changed the object structure and made all relevant changes for saving and importing.
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/fs-action.js 03acbf3 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/prepare-config-fs.js 3c425d9 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js 2ce0ab4 
>   contrib/views/wfmanager/src/main/resources/ui/app/templates/components/prepare-config-fs.hbs c549a26 
>   contrib/views/wfmanager/src/main/resources/ui/app/validators/fs-action-validator.js 4064379 
> 
> Diff: https://reviews.apache.org/r/55120/diff/
> 
> 
> Testing
> -------
> 
> We have created workflow with FS action editor, Saved it and imported it into WFD and tested the functionality.
> 
> 
> Thanks,
> 
> venkat sairam
> 
>


Re: Review Request 55120: Issue with FS action node in oozie workflow designer

Posted by venkat sairam <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55120/
-----------------------------------------------------------

(Updated Jan. 2, 2017, 1:41 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Renjith Kamath.


Changes
-------

Fixed the permissions format


Bugs: AMBARI-19332
    https://issues.apache.org/jira/browse/AMBARI-19332


Repository: ambari


Description
-------

There is an issue with the way object is saved.We have changed the object structure and made all relevant changes for saving and importing.


Diffs (updated)
-----

  contrib/views/wfmanager/src/main/resources/ui/app/components/fs-action.js 03acbf3 
  contrib/views/wfmanager/src/main/resources/ui/app/components/prepare-config-fs.js 3c425d9 
  contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js 2ce0ab4 
  contrib/views/wfmanager/src/main/resources/ui/app/templates/components/prepare-config-fs.hbs c549a26 
  contrib/views/wfmanager/src/main/resources/ui/app/validators/fs-action-validator.js 4064379 

Diff: https://reviews.apache.org/r/55120/diff/


Testing
-------

We have created workflow with FS action editor, Saved it and imported it into WFD and tested the functionality.


Thanks,

venkat sairam


Re: Review Request 55120: Issue with FS action node in oozie workflow designer

Posted by venkat sairam <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55120/
-----------------------------------------------------------

(Updated Jan. 2, 2017, 1:21 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Renjith Kamath.


Bugs: AMBARI-19332
    https://issues.apache.org/jira/browse/AMBARI-19332


Repository: ambari


Description
-------

There is an issue with the way object is saved.We have changed the object structure and made all relevant changes for saving and importing.


Diffs (updated)
-----

  contrib/views/wfmanager/src/main/resources/ui/app/components/fs-action.js 03acbf3 
  contrib/views/wfmanager/src/main/resources/ui/app/components/prepare-config-fs.js 3c425d9 
  contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js 2ce0ab4 
  contrib/views/wfmanager/src/main/resources/ui/app/templates/components/prepare-config-fs.hbs c549a26 
  contrib/views/wfmanager/src/main/resources/ui/app/validators/fs-action-validator.js 4064379 

Diff: https://reviews.apache.org/r/55120/diff/


Testing
-------

We have created workflow with FS action editor, Saved it and imported it into WFD and tested the functionality.


Thanks,

venkat sairam