You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by revans2 <gi...@git.apache.org> on 2015/01/07 23:21:48 UTC

[GitHub] storm pull request: update worker.clj-delete "missing-tasks" check...

Github user revans2 commented on the pull request:

    https://github.com/apache/storm/pull/288#issuecomment-69103211
  
    @BuDongDong from what I can tell you are correct on this.  My only comment is that you probably also want to remove ``` needed-tasks (-> needed-assignment keys)``` too, as needed-tasks is only used in the code you just deleted.  If you want to file a JIRA for this under STORM in http://issue.apache.org/jira  that would be great.  But I can do that if you would prefer.
    
    Sorry it took so long for me to review this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---