[jira] [Commented] (TIKA-701) Fix problems with TemporaryFiles

["Michael McCandless (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TIKA-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095363#comment-13095363 ] 

Michael McCandless commented on TIKA-701:
-----------------------------------------

These changes look great!

I like that TIS no longer closes the IS when the full file is read only when a mark wasn't set, nor do we close the old stream in getFile() (only when the TR is later closed).

I noticed one thing, that I'm not sure is a problem, but looks spooky: TikaInputStream.get can optionally take an incoming TemporaryResources; inside that method we have this logic:

{noformat}
        if (stream instanceof TikaInputStream) {
            return (TikaInputStream) stream;
        }
{noformat}

My worry is: what if the incoming TemporaryResources differs from the stream's?  I added an assert and it sometimes does differ (at least a couple tests tripped it).  Will this cause problems...?  Ie the returned TIS is not tracked under the provided TR as the caller would expect?

> Fix problems with TemporaryFiles
> --------------------------------
>
>                 Key: TIKA-701
>                 URL: https://issues.apache.org/jira/browse/TIKA-701
>             Project: Tika
>          Issue Type: Bug
>    Affects Versions: 0.9
>            Reporter: Jukka Zitting
>            Assignee: Jukka Zitting
>             Fix For: 1.0
>
>
> As discussed on dev@, there are still some design issues with the TemporaryFiles class that we introduced in TIKA-567. They should be solved in time for Tika 1.0.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira