[GitHub] [flink-table-store] tsreaper commented on a diff in pull request #410: [FLINK-30247] Introduce time travel reading for table store

[GitBox <gi...@apache.org>]

tsreaper commented on code in PR #410:
URL: https://github.com/apache/flink-table-store/pull/410#discussion_r1039215031


##########
docs/layouts/shortcodes/generated/core_configuration.html:
##########
@@ -8,6 +8,18 @@
         </tr>
     </thead>
     <tbody>
+        <tr>
+            <td><h5>as-of-snapshot</h5></td>
+            <td style="word-wrap: break-word;">(none)</td>
+            <td>Long</td>
+            <td>Read snapshot specific by snapshot id.</td>
+        </tr>
+        <tr>
+            <td><h5>as-of-timestamp-mills</h5></td>

Review Comment:
   Why introduce a new configuration? Time travel reading is actually very similar to the "from-timestamp" startup mode in streaming jobs. I'm considering supporting startup mode for both batch and streaming jobs. See https://issues.apache.org/jira/browse/FLINK-30294 .



##########
docs/content/docs/development/query-table.md:
##########
@@ -126,3 +126,14 @@ SELECT * FROM MyTable$options;
 +------------------------+--------------------+
 1 rows in set
 ```
+
+## Time Travel reading
+
+You can read snapshot specific by commit time or snapshot id from a table.
+```sql
+-- Read snapshot specific by commit time.
+SELECT * FROM T /+ OPTIONS('as-of-timestamp-mills'='121230')/;

Review Comment:
   Should be `/*+ OPTIONS(...) */`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org