You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by sachingoel0101 <gi...@git.apache.org> on 2015/08/01 20:03:06 UTC
[GitHub] flink pull request: [FLINK-2459][cli]Cli API and doc fixes.
GitHub user sachingoel0101 opened a pull request:
https://github.com/apache/flink/pull/971
[FLINK-2459][cli]Cli API and doc fixes.
1. Remove CliFrontendLoggingTest. Test directly that the logging flag is interpreted correctly.
2. [hotfix] Doc fix for cli api
3. [hotfix] Info command shouldn't print logging option for help.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sachingoel0101/flink logging_fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/971.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #971
----
commit 493cde177d4f105533e73a43ca593ae708d2dcb2
Author: Sachin Goel <sa...@gmail.com>
Date: 2015-08-01T15:34:39Z
[FLINK-2459][cli]Cli API and doc fixes.
1. Remove CliFrontendLoggingTest. Test directly that the logging flag is
interpreted correctly.
2. [hotfix] Doc fix for cli api
3. [hotfix] Info command shouldn't print logging option for help.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2459][cli]Cli API and doc fixes.
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/971
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2459][cli]Cli API and doc fixes.
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/971#issuecomment-127052994
The push to rename it to "quiet" came after the merge, so it did not get in...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2459][cli]Cli API and doc fixes.
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/971#issuecomment-127053005
Can you make a separate patch for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2459][cli]Cli API and doc fixes.
Posted by sachingoel0101 <gi...@git.apache.org>.
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/971#issuecomment-126943148
@mxm, you should verify if should we do away with the logging test since you reviewed it.
If not, the problem is easily fixed by setting a free port instead of always using the default port.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2459][cli]Cli API and doc fixes.
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/971#issuecomment-127036785
Merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2459][cli]Cli API and doc fixes.
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/971#issuecomment-127036783
This looks good, thanks you!
One followup issue: The flag to suppress the logging is `-q` or `--sysoutLogging`. The long version seems inconsistent with "q". It should probably be called `--quiet`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2459][cli]Cli API and doc fixes.
Posted by sachingoel0101 <gi...@git.apache.org>.
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/971#issuecomment-127040180
Pushed a fix for changing the name to `quiet`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2459][cli]Cli API and doc fixes.
Posted by sachingoel0101 <gi...@git.apache.org>.
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/971#issuecomment-127055248
@StephanEwen, I've force pushed this branch to only contain the name change. You can merge this again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---