You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2021/02/20 20:15:19 UTC
[GitHub] [qpid-dispatch] jiridanek opened a new pull request #1050: DISPATCH-1844 Leak of sys_mutex
jiridanek opened a new pull request #1050:
URL: https://github.com/apache/qpid-dispatch/pull/1050
```
69: ../src/router_core/core_link_endpoint.c:124:24: runtime error: store to misaligned address 0x616000147d9c for type 'uint64_t', which requires 8 byte alignment
69: 0x616000147d9c: note: pointer points here
69: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
69: ^
69:
69: =================================================================
69: ==3434==ERROR: LeakSanitizer: detected memory leaks
69:
69: Direct leak of 64 byte(s) in 1 object(s) allocated from:
69: #0 0x7f9b999adaa5 in posix_memalign (/lib/x86_64-linux-gnu/libasan.so.5+0x10eaa5)
69: #1 0x7f9b991917f4 in sys_mutex ../src/posix/threading.c:41
69: #2 0x7f9b9914e927 in qd_message ../src/message.c:1012
69: #3 0x7f9b992fdbbf in create_http2_stream_data ../src/adaptors/http2/http2_adaptor.c:399
69: #4 0x7f9b993197f0 in qdr_http_deliver ../src/adaptors/http2/http2_adaptor.c:1816
69: #5 0x7f9b9926e866 in qdr_link_process_deliveries ../src/router_core/transfer.c:175
69: #6 0x7f9b991c7d91 in qdr_connection_process ../src/router_core/connections.c:412
69: #7 0x7f9b9931ab70 in handle_connection_event ../src/adaptors/http2/http2_adaptor.c:2293
69: #8 0x7f9b992ce085 in handle_event_with_context ../src/server.c:804
69: #9 0x7f9b992ce085 in do_handle_raw_connection_event ../src/server.c:810
69: #10 0x7f9b992ce085 in handle ../src/server.c:1090
69: #11 0x7f9b992d65b5 in thread_run ../src/server.c:1122
69: #12 0x7f9b992d8aca in qd_server_run ../src/server.c:1484
69: #13 0x55c9b5e061bc in main_process ../router/src/main.c:113
69: #14 0x55c9b5e05ce0 in main ../router/src/main.c:367
69: #15 0x7f9b9802a0b2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x270b2)
69:
69: -----------------------------------------------------
69: Suppressions used:
69: count bytes template
69: 7 465 qd_dispatch_configure_connector
69: 7 65 load_server_config
69: 1 64 qd_message_receive
69: 1 24 ^pn_condition$
69: 1 1536 ^pn_raw_connection$
69: 1 56 qdr_core_subscribe
69: 10 5656 ^_PyObject_Realloc
69: 541 863651 ^PyObject_Malloc$
69: 1 32 ^PyThread_allocate_lock$
69: 4 9897 ^PyMem_Malloc$
69: 1 856 ^_PyObject_GC_Resize$
69: 5 248 ^pn_object_new$
69: 1 128 ^pn_list$
69: 2 48 ^pni_record_create$
69: -----------------------------------------------------
69:
69: SUMMARY: AddressSanitizer: 64 byte(s) leaked in 1 allocation(s).
69:
69: <<<<
69:
69: Router EDGE.A command file:
69: >>>>
69: qdrouterd -c edge-router.conf -I /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/python
69: pid=3434
```
```
69: 0x616000147d9c: note: pointer points here
69: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
69: ^
69:
69: =================================================================
69: ==3434==ERROR: LeakSanitizer: detected memory leaks
69:
69: Direct leak of 64 byte(s) in 1 object(s) allocated from:
69: #0 0x7f9b999adaa5 in posix_memalign (/lib/x86_64-linux-gnu/libasan.so.5+0x10eaa5)
69: #1 0x7f9b991917f4 in sys_mutex ../src/posix/threading.c:41
69: #2 0x7f9b9914e927 in qd_message ../src/message.c:1012
69: #3 0x7f9b992fdbbf in create_http2_stream_data ../src/adaptors/http2/http2_adaptor.c:399
69: #4 0x7f9b993197f0 in qdr_http_deliver ../src/adaptors/http2/http2_adaptor.c:1816
69: #5 0x7f9b9926e866 in qdr_link_process_deliveries ../src/router_core/transfer.c:175
69: #6 0x7f9b991c7d91 in qdr_connection_process ../src/router_core/connections.c:412
69: #7 0x7f9b9931ab70 in handle_connection_event ../src/adaptors/http2/http2_adaptor.c:2293
69: #8 0x7f9b992ce085 in handle_event_with_context ../src/server.c:804
69: #9 0x7f9b992ce085 in do_handle_raw_connection_event ../src/server.c:810
69: #10 0x7f9b992ce085 in handle ../src/server.c:1090
69: #11 0x7f9b992d65b5 in thread_run ../src/server.c:1122
69: #12 0x7f9b992d8aca in qd_server_run ../src/server.c:1484
69: #13 0x55c9b5e061bc in main_process ../router/src/main.c:113
69: #14 0x55c9b5e05ce0 in main ../router/src/main.c:367
69: #15 0x7f9b9802a0b2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x270b2)
69:
69: -----------------------------------------------------
69: Suppressions used:
69: count bytes template
69: 7 465 qd_dispatch_configure_connector
69: 7 65 load_server_config
69: 1 64 qd_message_receive
69: 1 24 ^pn_condition$
69: 1 1536 ^pn_raw_connection$
69: 1 56 qdr_core_subscribe
69: 10 5656 ^_PyObject_Realloc
69: 541 863651 ^PyObject_Malloc$
69: 1 32 ^PyThread_allocate_lock$
69: 4 9897 ^PyMem_Malloc$
69: 1 856 ^_PyObject_GC_Resize$
69: 5 248 ^pn_object_new$
69: 1 128 ^pn_list$
69: 2 48 ^pni_record_create$
69: -----------------------------------------------------
69:
69: SUMMARY: AddressSanitizer: 64 byte(s) leaked in 1 allocation(s).
69: <<<<
69:
69: ----------------------------------------------------------------------
69: Ran 77 tests in 93.566s
69:
69: FAILED (errors=1)
69: 'utf-8' codec can't decode byte 0xff in position 237: invalid start byte
69: 'utf-8' codec can't decode byte 0xff in position 237: invalid start byte
69: 'utf-8' codec can't decode byte 0xff in position 237: invalid start byte
69: 'utf-8' codec can't decode byte 0xff in position 237: invalid start byte
69: 'utf-8' codec can't decode byte 0xff in position 237: invalid start byte
69: 'utf-8' codec can't decode byte 0xff in position 237: invalid start byte
69: 'utf-8' codec can't decode byte 0xff in position 237: invalid start byte
35/37 Test #69: system_tests_http2 .............................***Failed 98.74 sec
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek closed pull request #1050: DISPATCH-1844 Leak of sys_mutex
Posted by GitBox <gi...@apache.org>.
jiridanek closed pull request #1050:
URL: https://github.com/apache/qpid-dispatch/pull/1050
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on pull request #1050: DISPATCH-1844 Leak of sys_mutex
Posted by GitBox <gi...@apache.org>.
jiridanek commented on pull request #1050:
URL: https://github.com/apache/qpid-dispatch/pull/1050#issuecomment-803295321
I've updated https://issues.apache.org/jira/browse/DISPATCH-1844 with a note that leak is still manifesting when running system_tests_http2. I will close the PR if I can't update it to fix the leak.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] ChugR commented on a change in pull request #1050: DISPATCH-1844 Leak of sys_mutex
Posted by GitBox <gi...@apache.org>.
ChugR commented on a change in pull request #1050:
URL: https://github.com/apache/qpid-dispatch/pull/1050#discussion_r584780043
##########
File path: cmake/RuntimeChecks.cmake
##########
@@ -106,9 +106,17 @@ elseif(RUNTIME_CHECK STREQUAL "asan")
message(FATAL_ERROR "libubsan not installed - address sanitizer not available")
endif(UBSAN_LIBRARY-NOTFOUND)
message(STATUS "Runtime memory checker: gcc/clang address sanitizers")
+ option(SANITIZE_3RD_PARTY "Detect leaks in 3rd party libraries used by Dispatch while running tests" OFF)
+ file (COPY "${CMAKE_SOURCE_DIR}/tests/lsan.supp" DESTINATION "${CMAKE_BINARY_DIR}/tests")
+ if (NOT SANITIZE_3RD_PARTY)
+ # Append wholesale library suppressions
+ # this is necessary if target system does not have debug symbols for these libraries installed
+ # and therefore the more specific suppressions do not match
+ file(APPEND "${CMAKE_BINARY_DIR}/tests/lsan.supp" "\nleak:/libpython2.*.so\nleak:/libpython3.*.so\n")
+ endif ()
set(SANITIZE_FLAGS "-g -fno-omit-frame-pointer -fsanitize=address,undefined")
set(RUNTIME_ASAN_ENV_OPTIONS "detect_leaks=true suppressions=${CMAKE_SOURCE_DIR}/tests/asan.supp")
- set(RUNTIME_LSAN_ENV_OPTIONS "suppressions=${CMAKE_SOURCE_DIR}/tests/lsan.supp")
+ set(RUNTIME_LSAN_ENV_OPTIONS "suppressions=${CMAKE_BINARY_DIR}/tests/lsan.supp")
Review comment:
Copying lsan.supp to BINARY_DIR is a good idea regardless of the rest of this PR. The self tests use SOURCE_DIR and BINARY_DIR in a mixed and confusing manner, like configuring system_tests_handle_failover.py.in back in to SOURCE_DIR, but that's the topic for another jira.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] ChugR commented on pull request #1050: DISPATCH-1844 Leak of sys_mutex
Posted by GitBox <gi...@apache.org>.
ChugR commented on pull request #1050:
URL: https://github.com/apache/qpid-dispatch/pull/1050#issuecomment-788015068
+0 This patch looks fine to be but I have no experience in the issues that it is addressing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1050: DISPATCH-1844 Leak of sys_mutex
Posted by GitBox <gi...@apache.org>.
jiridanek commented on a change in pull request #1050:
URL: https://github.com/apache/qpid-dispatch/pull/1050#discussion_r597046371
##########
File path: cmake/RuntimeChecks.cmake
##########
@@ -106,9 +106,17 @@ elseif(RUNTIME_CHECK STREQUAL "asan")
message(FATAL_ERROR "libubsan not installed - address sanitizer not available")
endif(UBSAN_LIBRARY-NOTFOUND)
message(STATUS "Runtime memory checker: gcc/clang address sanitizers")
+ option(SANITIZE_3RD_PARTY "Detect leaks in 3rd party libraries used by Dispatch while running tests" OFF)
+ file (COPY "${CMAKE_SOURCE_DIR}/tests/lsan.supp" DESTINATION "${CMAKE_BINARY_DIR}/tests")
+ if (NOT SANITIZE_3RD_PARTY)
+ # Append wholesale library suppressions
+ # this is necessary if target system does not have debug symbols for these libraries installed
+ # and therefore the more specific suppressions do not match
+ file(APPEND "${CMAKE_BINARY_DIR}/tests/lsan.supp" "\nleak:/libpython2.*.so\nleak:/libpython3.*.so\n")
+ endif ()
set(SANITIZE_FLAGS "-g -fno-omit-frame-pointer -fsanitize=address,undefined")
set(RUNTIME_ASAN_ENV_OPTIONS "detect_leaks=true suppressions=${CMAKE_SOURCE_DIR}/tests/asan.supp")
- set(RUNTIME_LSAN_ENV_OPTIONS "suppressions=${CMAKE_SOURCE_DIR}/tests/lsan.supp")
+ set(RUNTIME_LSAN_ENV_OPTIONS "suppressions=${CMAKE_BINARY_DIR}/tests/lsan.supp")
Review comment:
Problem is, in the PR it is done the wrong way. CMake only copies the files when you run cmake to configure the build. If you later change the source file and rebuild, the copy won't be updated. I have to use `configure_file` in cmake to achieve that update, as Ganesh pointed out in the main (not-WIP) PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on pull request #1050: DISPATCH-1844 Leak of sys_mutex
Posted by GitBox <gi...@apache.org>.
jiridanek commented on pull request #1050:
URL: https://github.com/apache/qpid-dispatch/pull/1050#issuecomment-788023043
@ChugR Thanks for having a look, but at this point, this and the other leak-fixing issues are not ready to be reviewed. I need to get in https://github.com/apache/qpid-dispatch/pull/1048 first, which will spell out all the suppressions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org