You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2017/11/13 23:16:54 UTC
Review Request 63768: Added 'ReconcileOfferOperations' reponse to
scheduler API.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63768/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Gaston Kleiman, Jie Yu, and Jan Schlicht.
Bugs: MESOS-8198
https://issues.apache.org/jira/browse/MESOS-8198
Repository: mesos
Description
-------
This patch adds the top-level `Response` message to the scheduler API,
along with the first response, `ReconcileOfferOperations`.
Diffs
-----
include/mesos/scheduler/scheduler.proto f5dda10a076ecae53a56875d0ed4d201a1c92f12
include/mesos/v1/scheduler/scheduler.proto 4fa6606b0db701aebe208b962b7768da68b180ab
Diff: https://reviews.apache.org/r/63768/diff/1/
Testing
-------
make check
Thanks,
Greg Mann
Re: Review Request 63768: Added 'ReconcileOfferOperations' reponse to
scheduler API.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63768/#review190942
-----------------------------------------------------------
FAIL: Some Mesos libprocess-tests failed.
Reviews applied: `['63767', '63768']`
Failed command: `C:\DCOS\mesos\3rdparty\libprocess\src\tests\Debug\libprocess-tests.exe`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63768
Relevant logs:
- [libprocess-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63768/logs/libprocess-tests-stdout.log):
```
[ OK ] Scheme/HTTPTest.WWWAuthenticateHeader/0 (715 ms)
[ RUN ] Scheme/HTTPTest.WWWAuthenticateHeader/1
[ OK ] Scheme/HTTPTest.WWWAuthenticateHeader/1 (71 ms)
[ RUN ] Scheme/HTTPTest.Accepts/0
[ OK ] Scheme/HTTPTest.Accepts/0 (803 ms)
[ RUN ] Scheme/HTTPTest.Accepts/1
[ OK ] Scheme/HTTPTest.Accepts/1 (87 ms)
[----------] 34 tests from Scheme/HTTPTest (13383 ms total)
[----------] 4 tests from SSLVerifyIPAdd/SSLTest
[ RUN ] SSLVerifyIPAdd/SSLTest.BasicSameProcess/0
[ OK ] SSLVerifyIPAdd/SSLTest.BasicSameProcess/0 (873 ms)
[ RUN ] SSLVerifyIPAdd/SSLTest.BasicSameProcess/1
[ OK ] SSLVerifyIPAdd/SSLTest.BasicSameProcess/1 (1125 ms)
[ RUN ] SSLVerifyIPAdd/SSLTest.RequireCertificate/0
[ OK ] SSLVerifyIPAdd/SSLTest.RequireCertificate/0 (932 ms)
[ RUN ] SSLVerifyIPAdd/SSLTest.RequireCertificate/1
[ OK ] SSLVerifyIPAdd/SSLTest.RequireCertificate/1 (599 ms)
[----------] 4 tests from SSLVerifyIPAdd/SSLTest (3660 ms total)
[----------] Global test environment tear-down
[==========] 201 tests from 33 test cases ran. (46029 ms total)
[ PASSED ] 200 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] SSLTest.ProtocolMismatch
1 FAILED TEST
YOU HAVE 19 DISABLED TESTS
```
- [libprocess-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63768/logs/libprocess-tests-stderr.log):
```
I1114 13WARNING: Logging before InitGoogleLogging() is written to STDERR
I1114 13:31:08.973026 5732 openssl.cpp:509] CA directory path unspecified! NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=<dirpath>
I1114 13:31:08.974030 5732 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I1114 13:31:08.974030 5732 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1114 13:31:08.974030 5732 openssl.cpp:563] Using CA file: C:\Users\mesos\AppData\Local\Temp\mpxpLK\cert.pem
WARNING: Logging before InitGoogleLogging() is written to STDERR
I1114 13:31:09.638362 3916 openssl.cpp:509] CA directory path unspecified! NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=<dirpath>
I1114 13:31:09.643370 3916 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I1114 13:31:09.643370 3916 openssl.cpp:526] Will use IP address verification in subject alternative name certificate extension.
I1114 13:31:09.644359 3916 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1114 13:31:09.644359 3916 openssl.cpp:563] Using CA file: C:\Users\mesos\AppData\Local\Temp\F7Cpnw\cert.pem
:31:08.679018 1596 openssl.cpp:509] CA directory path unspecified! NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=<dirpath>
I1114 13:31:08.687037 1596 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I1114 13:31:08.687037 1596 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1114 13:31:08.688019 1596 openssl.cpp:563] Using CA file: C:\Users\mesos\AppData\Local\Temp\mpxpLK\cert.pem
I1114 13:31:09.337347 1596 openssl.cpp:509] CA directory path unspecified! NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=<dirpath>
I1114 13:31:09.337347 1596 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I1114 13:31:09.342013 1596 openssl.cpp:526] Will use IP address verification in subject alternative name certificate extension.
I1114 13:31:09.342013 1596 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1114 13:31:09.342347 1596 openssl.cpp:563] Using CA file: C:\Users\mesos\AppData\Local\Temp\F7Cpnw\cert.pem
I1114 13:31:09.791648 1688 process.cpp:1052] Failed to accept socket: future discarded
```
- Mesos Reviewbot Windows
On Nov. 14, 2017, 12:25 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63768/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2017, 12:25 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-8198
> https://issues.apache.org/jira/browse/MESOS-8198
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added 'ReconcileOfferOperations' reponse to scheduler API.
>
>
> Diffs
> -----
>
> include/mesos/scheduler/scheduler.proto f5dda10a076ecae53a56875d0ed4d201a1c92f12
> include/mesos/v1/scheduler/scheduler.proto 4fa6606b0db701aebe208b962b7768da68b180ab
> src/scheduler/scheduler.cpp 286a7603352a1e639a0502e496d4409be11bf9d7
>
>
> Diff: https://reviews.apache.org/r/63768/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 63768: Added 'ReconcileOfferOperations' reponse to
scheduler API.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63768/#review190989
-----------------------------------------------------------
A few minor comments.
Also please `s/reponse/response/` in the patch summary =).
include/mesos/scheduler/scheduler.proto
Lines 211 (patched)
<https://reviews.apache.org/r/63768/#comment268574>
s/master operator API/scheduler API/
include/mesos/v1/scheduler/scheduler.proto
Lines 209 (patched)
<https://reviews.apache.org/r/63768/#comment268575>
Ditto.
- Gaston Kleiman
On Nov. 13, 2017, 3:25 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63768/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2017, 3:25 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-8198
> https://issues.apache.org/jira/browse/MESOS-8198
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added 'ReconcileOfferOperations' reponse to scheduler API.
>
>
> Diffs
> -----
>
> include/mesos/scheduler/scheduler.proto f5dda10a076ecae53a56875d0ed4d201a1c92f12
> include/mesos/v1/scheduler/scheduler.proto 4fa6606b0db701aebe208b962b7768da68b180ab
> src/scheduler/scheduler.cpp 286a7603352a1e639a0502e496d4409be11bf9d7
>
>
> Diff: https://reviews.apache.org/r/63768/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 63768: Added 'ReconcileOfferOperations' response to
scheduler API.
Posted by Greg Mann <gr...@mesosphere.io>.
> On Nov. 14, 2017, 10:12 p.m., Gaston Kleiman wrote:
> > src/scheduler/scheduler.cpp
> > Lines 123-124 (original), 123 (patched)
> > <https://reviews.apache.org/r/63768/diff/3/?file=1892143#file1892143line123>
> >
> > For consistency I think that it'd also be nice to remove the `using process::http::Request` statement.
> >
> > Also I noticed that we use `::Request` in this file... so removing the `using` statement and replacing `::Request` with the more explicit `process::http::Request` feels to me like an improvement.
Good call; I added another patch to do this: https://reviews.apache.org/r/63850/
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63768/#review191007
-----------------------------------------------------------
On Nov. 14, 2017, 9:44 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63768/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2017, 9:44 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-8198
> https://issues.apache.org/jira/browse/MESOS-8198
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a first-class `Response` message to the scheduler API
> along with its first member, the `ReconcileOfferOperations` response
> message.
>
>
> Diffs
> -----
>
> include/mesos/scheduler/scheduler.proto f5dda10a076ecae53a56875d0ed4d201a1c92f12
> include/mesos/v1/scheduler/scheduler.proto 4fa6606b0db701aebe208b962b7768da68b180ab
> src/scheduler/scheduler.cpp 286a7603352a1e639a0502e496d4409be11bf9d7
>
>
> Diff: https://reviews.apache.org/r/63768/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 63768: Added 'ReconcileOfferOperations' response to
scheduler API.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63768/#review191007
-----------------------------------------------------------
Fix it, then Ship it!
src/scheduler/scheduler.cpp
Lines 123-124 (original), 123 (patched)
<https://reviews.apache.org/r/63768/#comment268595>
For consistency I think that it'd also be nice to remove the `using process::http::Request` statement.
Also I noticed that we use `::Request` in this file... so removing the `using` statement and replacing `::Request` with the more explicit `process::http::Request` feels to me like an improvement.
- Gaston Kleiman
On Nov. 14, 2017, 1:44 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63768/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2017, 1:44 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-8198
> https://issues.apache.org/jira/browse/MESOS-8198
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a first-class `Response` message to the scheduler API
> along with its first member, the `ReconcileOfferOperations` response
> message.
>
>
> Diffs
> -----
>
> include/mesos/scheduler/scheduler.proto f5dda10a076ecae53a56875d0ed4d201a1c92f12
> include/mesos/v1/scheduler/scheduler.proto 4fa6606b0db701aebe208b962b7768da68b180ab
> src/scheduler/scheduler.cpp 286a7603352a1e639a0502e496d4409be11bf9d7
>
>
> Diff: https://reviews.apache.org/r/63768/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 63768: Added 'ReconcileOfferOperations' response to
scheduler API.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63768/
-----------------------------------------------------------
(Updated Nov. 14, 2017, 9:44 p.m.)
Review request for mesos, Benjamin Bannier, Gaston Kleiman, Jie Yu, and Jan Schlicht.
Bugs: MESOS-8198
https://issues.apache.org/jira/browse/MESOS-8198
Repository: mesos
Description
-------
This patch adds a first-class `Response` message to the scheduler API
along with its first member, the `ReconcileOfferOperations` response
message.
Diffs (updated)
-----
include/mesos/scheduler/scheduler.proto f5dda10a076ecae53a56875d0ed4d201a1c92f12
include/mesos/v1/scheduler/scheduler.proto 4fa6606b0db701aebe208b962b7768da68b180ab
src/scheduler/scheduler.cpp 286a7603352a1e639a0502e496d4409be11bf9d7
Diff: https://reviews.apache.org/r/63768/diff/3/
Changes: https://reviews.apache.org/r/63768/diff/2-3/
Testing
-------
make check
Thanks,
Greg Mann
Re: Review Request 63768: Added 'ReconcileOfferOperations' response to
scheduler API.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63768/
-----------------------------------------------------------
(Updated Nov. 14, 2017, 8:48 p.m.)
Review request for mesos, Benjamin Bannier, Gaston Kleiman, Jie Yu, and Jan Schlicht.
Summary (updated)
-----------------
Added 'ReconcileOfferOperations' response to scheduler API.
Bugs: MESOS-8198
https://issues.apache.org/jira/browse/MESOS-8198
Repository: mesos
Description (updated)
-------
This patch adds a first-class `Response` message to the scheduler API
along with its first member, the `ReconcileOfferOperations` response
message.
Diffs
-----
include/mesos/scheduler/scheduler.proto f5dda10a076ecae53a56875d0ed4d201a1c92f12
include/mesos/v1/scheduler/scheduler.proto 4fa6606b0db701aebe208b962b7768da68b180ab
src/scheduler/scheduler.cpp 286a7603352a1e639a0502e496d4409be11bf9d7
Diff: https://reviews.apache.org/r/63768/diff/2/
Testing
-------
make check
Thanks,
Greg Mann
Re: Review Request 63768: Added 'ReconcileOfferOperations' reponse to
scheduler API.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63768/
-----------------------------------------------------------
(Updated Nov. 13, 2017, 11:25 p.m.)
Review request for mesos, Benjamin Bannier, Gaston Kleiman, Jie Yu, and Jan Schlicht.
Bugs: MESOS-8198
https://issues.apache.org/jira/browse/MESOS-8198
Repository: mesos
Description (updated)
-------
Added 'ReconcileOfferOperations' reponse to scheduler API.
Diffs (updated)
-----
include/mesos/scheduler/scheduler.proto f5dda10a076ecae53a56875d0ed4d201a1c92f12
include/mesos/v1/scheduler/scheduler.proto 4fa6606b0db701aebe208b962b7768da68b180ab
src/scheduler/scheduler.cpp 286a7603352a1e639a0502e496d4409be11bf9d7
Diff: https://reviews.apache.org/r/63768/diff/2/
Changes: https://reviews.apache.org/r/63768/diff/1-2/
Testing
-------
make check
Thanks,
Greg Mann