You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "dpogue (via GitHub)" <gi...@apache.org> on 2024/08/02 23:54:57 UTC
[PR] chore: Minor test fixes [cordova-common]
dpogue opened a new pull request, #211:
URL: https://github.com/apache/cordova-common/pull/211
### Platforms affected
None
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
Resolves some deprecations warnings printed to the console in Node 22.
### Description
<!-- Describe your changes in detail -->
* The `fs.Stats` constructor is deprecated in Node 22 and prints a warning to the console, so we want to find a way to avoid hitting that
* We got some warnings elsewhere that temporary files weren't cleaned up properly after test runs. Try using the `tmp` npm module to handle this better
### Testing
<!-- Please describe in detail how you tested your changes. -->
Ran unit tests locally on Node 22.
### Checklist
- [x] I've run the tests to see all new and existing tests pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] chore: Minor test fixes [cordova-common]
Posted by "dpogue (via GitHub)" <gi...@apache.org>.
dpogue merged PR #211:
URL: https://github.com/apache/cordova-common/pull/211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] chore: Minor test fixes [cordova-common]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #211:
URL: https://github.com/apache/cordova-common/pull/211#issuecomment-2266273397
## [Codecov](https://app.codecov.io/gh/apache/cordova-common/pull/211?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 88.40%. Comparing base [(`3d7f736`)](https://app.codecov.io/gh/apache/cordova-common/commit/3d7f7360273b90c73d263f2fa42eaf0daca453ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`52b849a`)](https://app.codecov.io/gh/apache/cordova-common/commit/52b849a11426569e392c84421d8f59ece6f41c2d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #211 +/- ##
=======================================
Coverage 88.40% 88.40%
=======================================
Files 20 20
Lines 1147 1147
=======================================
Hits 1014 1014
Misses 133 133
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cordova-common/pull/211?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org