You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/04/08 01:26:51 UTC

[GitHub] [hudi] KnightChess opened a new pull request, #5215: [HUDI-3781] fix spark delete sql can not delete record

KnightChess opened a new pull request, #5215:
URL: https://github.com/apache/hudi/pull/5215

   ## What is the purpose of the pull request
   
   fix can not delete record by use  spark sql. operation.key must be "delete"
   
   ## Brief change log
   
   *(for example:)*
     - *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
     - *Added integration tests for end-to-end.*
     - *Added HoodieClientWriteTest to verify the change.*
     - *Manually verified the change by running a job locally.*
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] KnightChess commented on pull request #5215: [HUDI-3781] fix spark delete sql can not delete record

Posted by GitBox <gi...@apache.org>.
KnightChess commented on PR #5215:
URL: https://github.com/apache/hudi/pull/5215#issuecomment-1089676484

   fix conflicts


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #5215: [HUDI-3781] fix spark delete sql can not delete record

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5215:
URL: https://github.com/apache/hudi/pull/5215#issuecomment-1089682899

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "11b8b2b4c6a6e0d09c5ef689e5223f663f588def",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7756",
       "triggerID" : "11b8b2b4c6a6e0d09c5ef689e5223f663f588def",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e4560a3b477781f77ae3295340c31e4d7ce4b526",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7781",
       "triggerID" : "e4560a3b477781f77ae3295340c31e4d7ce4b526",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79f41c8c57fe87a89e17e6c89ecb8fd3978fe78d",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7786",
       "triggerID" : "79f41c8c57fe87a89e17e6c89ecb8fd3978fe78d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79f41c8c57fe87a89e17e6c89ecb8fd3978fe78d",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7789",
       "triggerID" : "1086837609",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "0f2fe349a048d1981a2aacb15ae2ac743becc7a6",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7854",
       "triggerID" : "0f2fe349a048d1981a2aacb15ae2ac743becc7a6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 79f41c8c57fe87a89e17e6c89ecb8fd3978fe78d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7786) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7789) 
   * 0f2fe349a048d1981a2aacb15ae2ac743becc7a6 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7854) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] XuQianJin-Stars commented on pull request #5215: [HUDI-3781] fix spark delete sql can not delete record

Posted by GitBox <gi...@apache.org>.
XuQianJin-Stars commented on PR #5215:
URL: https://github.com/apache/hudi/pull/5215#issuecomment-1091695966

   > @XuQianJin-Stars how to retrigger it?
   
   reopen this pr or commit pr comments.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #5215: [HUDI-3781] fix spark delete sql can not delete record

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5215:
URL: https://github.com/apache/hudi/pull/5215#issuecomment-1089679905

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "11b8b2b4c6a6e0d09c5ef689e5223f663f588def",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7756",
       "triggerID" : "11b8b2b4c6a6e0d09c5ef689e5223f663f588def",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e4560a3b477781f77ae3295340c31e4d7ce4b526",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7781",
       "triggerID" : "e4560a3b477781f77ae3295340c31e4d7ce4b526",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79f41c8c57fe87a89e17e6c89ecb8fd3978fe78d",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7786",
       "triggerID" : "79f41c8c57fe87a89e17e6c89ecb8fd3978fe78d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79f41c8c57fe87a89e17e6c89ecb8fd3978fe78d",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7789",
       "triggerID" : "1086837609",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "0f2fe349a048d1981a2aacb15ae2ac743becc7a6",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0f2fe349a048d1981a2aacb15ae2ac743becc7a6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 79f41c8c57fe87a89e17e6c89ecb8fd3978fe78d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7786) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7789) 
   * 0f2fe349a048d1981a2aacb15ae2ac743becc7a6 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] KnightChess closed pull request #5215: [HUDI-3781] fix spark delete sql can not delete record

Posted by GitBox <gi...@apache.org>.
KnightChess closed pull request #5215: [HUDI-3781] fix spark delete sql can not delete record
URL: https://github.com/apache/hudi/pull/5215


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] KnightChess commented on pull request #5215: [HUDI-3781] fix spark delete sql can not delete record

Posted by GitBox <gi...@apache.org>.
KnightChess commented on PR #5215:
URL: https://github.com/apache/hudi/pull/5215#issuecomment-1091690934

   @XuQianJin-Stars how to retrigger it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] xiarixiaoyao commented on pull request #5215: [HUDI-3781] fix spark delete sql can not delete record

Posted by GitBox <gi...@apache.org>.
xiarixiaoyao commented on PR #5215:
URL: https://github.com/apache/hudi/pull/5215#issuecomment-1092484913

   @KnightChess  thanks for your contribution.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] XuQianJin-Stars commented on pull request #5215: [HUDI-3781] fix spark delete sql can not delete record

Posted by GitBox <gi...@apache.org>.
XuQianJin-Stars commented on PR #5215:
URL: https://github.com/apache/hudi/pull/5215#issuecomment-1091656699

   hi @KnightChess Retrigger the CI of the github action.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] KnightChess commented on pull request #5215: [HUDI-3781] fix spark delete sql can not delete record

Posted by GitBox <gi...@apache.org>.
KnightChess commented on PR #5215:
URL: https://github.com/apache/hudi/pull/5215#issuecomment-1091693575

   > @KnightChess @XuQianJin-Stars how about forbidden set hoodie.datasource.write.operation when we create hudi table. maybe we can do some check when we create table， or ignore this paramter and print some log for it.
   
   @xiarixiaoyao in #5248 , I think check is better


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] KnightChess commented on pull request #5215: [HUDI-3781] fix spark delete sql can not delete record

Posted by GitBox <gi...@apache.org>.
KnightChess commented on PR #5215:
URL: https://github.com/apache/hudi/pull/5215#issuecomment-1091399157

   other command has the same question, I open  a issue to discuss #5248 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #5215: [HUDI-3781] fix spark delete sql can not delete record

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5215:
URL: https://github.com/apache/hudi/pull/5215#issuecomment-1089820081

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "11b8b2b4c6a6e0d09c5ef689e5223f663f588def",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7756",
       "triggerID" : "11b8b2b4c6a6e0d09c5ef689e5223f663f588def",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e4560a3b477781f77ae3295340c31e4d7ce4b526",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7781",
       "triggerID" : "e4560a3b477781f77ae3295340c31e4d7ce4b526",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79f41c8c57fe87a89e17e6c89ecb8fd3978fe78d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7786",
       "triggerID" : "79f41c8c57fe87a89e17e6c89ecb8fd3978fe78d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79f41c8c57fe87a89e17e6c89ecb8fd3978fe78d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7789",
       "triggerID" : "1086837609",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "0f2fe349a048d1981a2aacb15ae2ac743becc7a6",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7854",
       "triggerID" : "0f2fe349a048d1981a2aacb15ae2ac743becc7a6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0f2fe349a048d1981a2aacb15ae2ac743becc7a6 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7854) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] xiarixiaoyao merged pull request #5215: [HUDI-3781] fix spark delete sql can not delete record

Posted by GitBox <gi...@apache.org>.
xiarixiaoyao merged PR #5215:
URL: https://github.com/apache/hudi/pull/5215


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] xiarixiaoyao commented on pull request #5215: [HUDI-3781] fix spark delete sql can not delete record

Posted by GitBox <gi...@apache.org>.
xiarixiaoyao commented on PR #5215:
URL: https://github.com/apache/hudi/pull/5215#issuecomment-1091674787

   @KnightChess   @XuQianJin-Stars  how about forbidden set hoodie.datasource.write.operation  when we create hudi table.
   maybe we can do some check when we create table， or ignore this paramter and print some log for it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org