You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2016/08/29 12:17:03 UTC
Review Request 51490: LENS-1300: Queries submissions are not getting
rejected on sessions marked for close
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51490/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-1300
https://issues.apache.org/jira/browse/LENS-1300
Repository: lens
Description
-------
Diffs
-----
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java e0e4bf8d9b36541e347424401ba41c79d034dddc
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java a6013e7a9ebd5e03cc58df99844e4b54daceda3f
lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSessionClose.java 202e4bedce6c9847f6531f3ec6c4a1a79a707835
Diff: https://reviews.apache.org/r/51490/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 51490: LENS-1300: Queries submissions are not
getting rejected on sessions marked for close
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51490/#review147815
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On Aug. 30, 2016, 10 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51490/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2016, 10 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1300
> https://issues.apache.org/jira/browse/LENS-1300
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java 80ce0307943604fed2d576a995da33a6c879b476
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java e0e4bf8d9b36541e347424401ba41c79d034dddc
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 89090987116a937884786d32396c7155c9b4bcca
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java a6013e7a9ebd5e03cc58df99844e4b54daceda3f
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSessionClose.java 202e4bedce6c9847f6531f3ec6c4a1a79a707835
>
> Diff: https://reviews.apache.org/r/51490/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 51490: LENS-1300: Queries submissions are not
getting rejected on sessions marked for close
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On Sept. 2, 2016, 11:52 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java, line 476
> > <https://reviews.apache.org/r/51490/diff/2/?file=1488437#file1488437line476>
> >
> > Who is the caller of this method?
Right now, only test code. But the idea was that it can be extended to REST api too, in case we need an api to cleanup idle sessions on demand. Haven't added that code yet.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51490/#review147629
-----------------------------------------------------------
On Aug. 30, 2016, 3:30 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51490/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2016, 3:30 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1300
> https://issues.apache.org/jira/browse/LENS-1300
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java 80ce0307943604fed2d576a995da33a6c879b476
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java e0e4bf8d9b36541e347424401ba41c79d034dddc
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 89090987116a937884786d32396c7155c9b4bcca
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java a6013e7a9ebd5e03cc58df99844e4b54daceda3f
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSessionClose.java 202e4bedce6c9847f6531f3ec6c4a1a79a707835
>
> Diff: https://reviews.apache.org/r/51490/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 51490: LENS-1300: Queries submissions are not
getting rejected on sessions marked for close
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51490/#review147629
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java (line 474)
<https://reviews.apache.org/r/51490/#comment214835>
Who is the caller of this method?
- Amareshwari Sriramadasu
On Aug. 30, 2016, 10 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51490/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2016, 10 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1300
> https://issues.apache.org/jira/browse/LENS-1300
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java 80ce0307943604fed2d576a995da33a6c879b476
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java e0e4bf8d9b36541e347424401ba41c79d034dddc
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 89090987116a937884786d32396c7155c9b4bcca
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java a6013e7a9ebd5e03cc58df99844e4b54daceda3f
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSessionClose.java 202e4bedce6c9847f6531f3ec6c4a1a79a707835
>
> Diff: https://reviews.apache.org/r/51490/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 51490: LENS-1300: Queries submissions are not
getting rejected on sessions marked for close
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51490/
-----------------------------------------------------------
(Updated Sept. 7, 2016, 1:08 p.m.)
Review request for lens.
Bugs: LENS-1300
https://issues.apache.org/jira/browse/LENS-1300
Repository: lens
Description
-------
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/APIResult.java 26e99265f8437fedfcb093ad61ba1f810c026516
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java 80ce0307943604fed2d576a995da33a6c879b476
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java e0e4bf8d9b36541e347424401ba41c79d034dddc
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 89090987116a937884786d32396c7155c9b4bcca
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java a6013e7a9ebd5e03cc58df99844e4b54daceda3f
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java a4e61c4987c7b96bba47e9b643b746e89e195b1d
lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSessionClose.java 202e4bedce6c9847f6531f3ec6c4a1a79a707835
Diff: https://reviews.apache.org/r/51490/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 51490: LENS-1300: Queries submissions are not
getting rejected on sessions marked for close
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51490/
-----------------------------------------------------------
(Updated Sept. 7, 2016, 12:38 p.m.)
Review request for lens.
Bugs: LENS-1300
https://issues.apache.org/jira/browse/LENS-1300
Repository: lens
Description
-------
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/APIResult.java 26e99265f8437fedfcb093ad61ba1f810c026516
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java 80ce0307943604fed2d576a995da33a6c879b476
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java e0e4bf8d9b36541e347424401ba41c79d034dddc
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 89090987116a937884786d32396c7155c9b4bcca
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java a6013e7a9ebd5e03cc58df99844e4b54daceda3f
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java a4e61c4987c7b96bba47e9b643b746e89e195b1d
lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSessionClose.java 202e4bedce6c9847f6531f3ec6c4a1a79a707835
Diff: https://reviews.apache.org/r/51490/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 51490: LENS-1300: Queries submissions are not
getting rejected on sessions marked for close
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51490/
-----------------------------------------------------------
(Updated Aug. 30, 2016, 3:30 p.m.)
Review request for lens.
Bugs: LENS-1300
https://issues.apache.org/jira/browse/LENS-1300
Repository: lens
Description
-------
Diffs (updated)
-----
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java 80ce0307943604fed2d576a995da33a6c879b476
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java e0e4bf8d9b36541e347424401ba41c79d034dddc
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 89090987116a937884786d32396c7155c9b4bcca
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java a6013e7a9ebd5e03cc58df99844e4b54daceda3f
lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSessionClose.java 202e4bedce6c9847f6531f3ec6c4a1a79a707835
Diff: https://reviews.apache.org/r/51490/diff/
Testing
-------
Thanks,
Rajat Khandelwal