[GitHub] [incubator-doris] chaoyli commented on a change in pull request #2796: Improve comparison and printing of Version

[GitBox <gi...@apache.org>]

chaoyli commented on a change in pull request #2796: Improve comparison and printing of Version
URL: https://github.com/apache/incubator-doris/pull/2796#discussion_r368273807
 
 

 ##########
 File path: be/src/olap/tablet.cpp
 ##########
 @@ -272,16 +255,11 @@ OLAPStatus Tablet::add_rowset(RowsetSharedPtr rowset, bool need_persist) {
     // yiguolei: temp code, should remove the rowset contains by this rowset
     // but it should be removed in multi path version
     for (auto& it : _rs_version_map) {
 
 Review comment:
   it is not correspond with the definition of contains() function

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org