You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by "Carsten Ziegeler (JIRA)" <ji...@apache.org> on 2009/01/28 22:30:59 UTC
[jira] Created: (COCOON3-22) Remove XMLConsumer interface
Remove XMLConsumer interface
----------------------------
Key: COCOON3-22
URL: https://issues.apache.org/jira/browse/COCOON3-22
Project: Cocoon 3
Issue Type: Improvement
Components: cocoon-sax
Affects Versions: 3.0.0-alpha-1
Reporter: Carsten Ziegeler
Assignee: Cocoon Developers Team
Fix For: 3.0.0-alpha-2
Remove XMLConsumer interface; relying on a content handler which might optionally implement lexical handler is sufficient and simplifies the module
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (COCOON3-22) Remove XMLConsumer
interface
Posted by "Reinhard Poetz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON3-22?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12674709#action_12674709 ]
reinhard@apache.org edited comment on COCOON3-22 at 2/18/09 9:39 AM:
----------------------------------------------------------------
The patch doesn't cover the cocoon-stax module :-(
BTW, there is it.bat (or it.sh of *nix) that runs all unit and integration tests and performs license header checks.
was (Author: reinhard@apache.org):
The patch doesn't cover the cocoon-stax module :-(
> Remove XMLConsumer interface
> ----------------------------
>
> Key: COCOON3-22
> URL: https://issues.apache.org/jira/browse/COCOON3-22
> Project: Cocoon 3
> Issue Type: Improvement
> Components: cocoon-sax
> Affects Versions: 3.0.0-alpha-1
> Reporter: Carsten Ziegeler
> Assignee: Cocoon Developers Team
> Fix For: 3.0.0-alpha-2
>
> Attachments: cocoon-3.patch, StAX-classes.png
>
>
> Remove XMLConsumer interface; relying on a content handler which might optionally implement lexical handler is sufficient and simplifies the module
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COCOON3-22) Remove XMLConsumer interface
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON3-22?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12674718#action_12674718 ]
Carsten Ziegeler commented on COCOON3-22:
-----------------------------------------
Ah yes, it doesn't cover this as I don't have Java 6 on my machine :(
But I can update the patch
> Remove XMLConsumer interface
> ----------------------------
>
> Key: COCOON3-22
> URL: https://issues.apache.org/jira/browse/COCOON3-22
> Project: Cocoon 3
> Issue Type: Improvement
> Components: cocoon-sax
> Affects Versions: 3.0.0-alpha-1
> Reporter: Carsten Ziegeler
> Assignee: Cocoon Developers Team
> Fix For: 3.0.0-alpha-2
>
> Attachments: cocoon-3.patch, StAX-classes.png
>
>
> Remove XMLConsumer interface; relying on a content handler which might optionally implement lexical handler is sufficient and simplifies the module
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COCOON3-22) Remove XMLConsumer interface
Posted by "Jakob Spörk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON3-22?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12668368#action_12668368 ]
Jakob Spörk commented on COCOON3-22:
------------------------------------
I'm of the same opinion as Andreas. Only because removing the XConsumer and XProducer interfaces will work for SAX, I wouldn't do that because it would destroy the described similarities between different pipeline APIs.
I also do not see the advantage in removing these interface because this wont affect the performance and when dealing with writing components, the developer will only need transformers (AbstractTransformer), generators (AbstractGenerator) and serializer (AbstractSerializter) and has not to touch any of the interfaces.
I think one page of user manual will provider more clarity to new users than the removal of these interfaces.
> Remove XMLConsumer interface
> ----------------------------
>
> Key: COCOON3-22
> URL: https://issues.apache.org/jira/browse/COCOON3-22
> Project: Cocoon 3
> Issue Type: Improvement
> Components: cocoon-sax
> Affects Versions: 3.0.0-alpha-1
> Reporter: Carsten Ziegeler
> Assignee: Cocoon Developers Team
> Fix For: 3.0.0-alpha-2
>
> Attachments: StAX-classes.png
>
>
> Remove XMLConsumer interface; relying on a content handler which might optionally implement lexical handler is sufficient and simplifies the module
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COCOON3-22) Remove XMLConsumer interface
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON3-22?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler updated COCOON3-22:
------------------------------------
Attachment: cocoon-3.patch
Proposed patch
> Remove XMLConsumer interface
> ----------------------------
>
> Key: COCOON3-22
> URL: https://issues.apache.org/jira/browse/COCOON3-22
> Project: Cocoon 3
> Issue Type: Improvement
> Components: cocoon-sax
> Affects Versions: 3.0.0-alpha-1
> Reporter: Carsten Ziegeler
> Assignee: Cocoon Developers Team
> Fix For: 3.0.0-alpha-2
>
> Attachments: cocoon-3.patch, StAX-classes.png
>
>
> Remove XMLConsumer interface; relying on a content handler which might optionally implement lexical handler is sufficient and simplifies the module
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COCOON3-22) Remove XMLConsumer interface
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON3-22?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12668370#action_12668370 ]
Carsten Ziegeler commented on COCOON3-22:
-----------------------------------------
Ok, having worked with the xml consumer interface for years now, I came to the conclusion that things get much simpler if you just rely on content handler
It makes using the sax stuff much easier and more convenient - I don't think that we need to keep the stax stuff and other impl in sync just for the sake of having them in sync.
But please let's do this discussion in the mailing list - i've started an RT some days ago about this topic and so far got only positive response (from Sylvain)
> Remove XMLConsumer interface
> ----------------------------
>
> Key: COCOON3-22
> URL: https://issues.apache.org/jira/browse/COCOON3-22
> Project: Cocoon 3
> Issue Type: Improvement
> Components: cocoon-sax
> Affects Versions: 3.0.0-alpha-1
> Reporter: Carsten Ziegeler
> Assignee: Cocoon Developers Team
> Fix For: 3.0.0-alpha-2
>
> Attachments: StAX-classes.png
>
>
> Remove XMLConsumer interface; relying on a content handler which might optionally implement lexical handler is sufficient and simplifies the module
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (COCOON3-22) Remove XMLConsumer interface
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON3-22?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler closed COCOON3-22.
-----------------------------------
Resolution: Won't Fix
> Remove XMLConsumer interface
> ----------------------------
>
> Key: COCOON3-22
> URL: https://issues.apache.org/jira/browse/COCOON3-22
> Project: Cocoon 3
> Issue Type: Improvement
> Components: cocoon-sax
> Affects Versions: 3.0.0-alpha-1
> Reporter: Carsten Ziegeler
> Assignee: Cocoon Developers Team
> Fix For: 3.0.0-alpha-2
>
> Attachments: cocoon-3.patch, cocoon-stax.patch, StAX-classes.png
>
>
> Remove XMLConsumer interface; relying on a content handler which might optionally implement lexical handler is sufficient and simplifies the module
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COCOON3-22) Remove XMLConsumer interface
Posted by "Reinhard Poetz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON3-22?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12674709#action_12674709 ]
Reinhard Poetz commented on COCOON3-22:
---------------------------------------
The patch doesn't cover the cocoon-stax module :-(
> Remove XMLConsumer interface
> ----------------------------
>
> Key: COCOON3-22
> URL: https://issues.apache.org/jira/browse/COCOON3-22
> Project: Cocoon 3
> Issue Type: Improvement
> Components: cocoon-sax
> Affects Versions: 3.0.0-alpha-1
> Reporter: Carsten Ziegeler
> Assignee: Cocoon Developers Team
> Fix For: 3.0.0-alpha-2
>
> Attachments: cocoon-3.patch, StAX-classes.png
>
>
> Remove XMLConsumer interface; relying on a content handler which might optionally implement lexical handler is sufficient and simplifies the module
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COCOON3-22) Remove XMLConsumer interface
Posted by "Andreas Pieber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON3-22?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Pieber updated COCOON3-22:
----------------------------------
Attachment: StAX-classes.png
I'm not quite sure what I should think about this idea. On one hand it would eliminate not really required interfaces which is quite a good idea, but on the other hand it would (IMO) also create complexity on an other side. I attached a very simple class diagram of the cocoon-stax component. If you replace StAX (in the names) with Image you'll see the base architecture of the image-component proposed by Steven. Replacing StAX with SAX would produce the very basic architecture of the cocoon-sax module. And replacing StAX with any other name will (hopefully) produce the base architecture of any other future pipeline module.
So, if you're familiar with one component (e.g. StAX) you can very easily transfer your knowledge to any other component, since the basic architecture (NAMEProducer, NAMEConsumer, ...) is the very same throughout all components. From that point of view it may be a better idea to rename XMLConsumer and XMLProducer to SAXConsumer and SAXProducer instead of removing them.
Of course I'm not sure in how far this assumption will hold for all future components...
WDYT about that?
> Remove XMLConsumer interface
> ----------------------------
>
> Key: COCOON3-22
> URL: https://issues.apache.org/jira/browse/COCOON3-22
> Project: Cocoon 3
> Issue Type: Improvement
> Components: cocoon-sax
> Affects Versions: 3.0.0-alpha-1
> Reporter: Carsten Ziegeler
> Assignee: Cocoon Developers Team
> Fix For: 3.0.0-alpha-2
>
> Attachments: StAX-classes.png
>
>
> Remove XMLConsumer interface; relying on a content handler which might optionally implement lexical handler is sufficient and simplifies the module
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COCOON3-22) Remove XMLConsumer interface
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON3-22?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler updated COCOON3-22:
------------------------------------
Attachment: cocoon-stax.patch
> Remove XMLConsumer interface
> ----------------------------
>
> Key: COCOON3-22
> URL: https://issues.apache.org/jira/browse/COCOON3-22
> Project: Cocoon 3
> Issue Type: Improvement
> Components: cocoon-sax
> Affects Versions: 3.0.0-alpha-1
> Reporter: Carsten Ziegeler
> Assignee: Cocoon Developers Team
> Fix For: 3.0.0-alpha-2
>
> Attachments: cocoon-3.patch, cocoon-stax.patch, StAX-classes.png
>
>
> Remove XMLConsumer interface; relying on a content handler which might optionally implement lexical handler is sufficient and simplifies the module
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.