You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2023/05/23 02:20:02 UTC
[GitHub] [spark] zhengruifeng opened a new pull request, #41272: [WIP][PYTHON][CONNECT] Hide unsupported functions from auto-completion
zhengruifeng opened a new pull request, #41272:
URL: https://github.com/apache/spark/pull/41272
### What changes were proposed in this pull request?
move unsupported functions to `__getattr__`, except `getActiveSession` (this method doesn't work for `classmethod`)
### Why are the changes needed?
Hide unsupported functions from auto-completion
before:
<img width="1464" alt="image" src="https://github.com/apache/spark/assets/7322292/6a3efc83-99ed-4b73-b681-13640b3de7a0">
after:
<img width="1311" alt="image" src="https://github.com/apache/spark/assets/7322292/79366a32-718b-4208-ae1f-3e749971d6d2">
### Does this PR introduce _any_ user-facing change?
yes
### How was this patch tested?
manually check in `ipython`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng closed pull request #41272: [SPARK-43740][PYTHON][CONNECT] Hide unsupported `session` methods from auto-completion
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #41272: [SPARK-43740][PYTHON][CONNECT] Hide unsupported `session` methods from auto-completion
URL: https://github.com/apache/spark/pull/41272
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #41272: [SPARK-43740][PYTHON][CONNECT] Hide unsupported `session` methods from auto-completion
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #41272:
URL: https://github.com/apache/spark/pull/41272#issuecomment-1558890037
merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org