You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Chris Hostetter <ho...@fucit.org> on 2014/08/22 18:58:36 UTC
Re: svn commit: r1619630 - in /lucene/dev/branches/branch_4x: ./
build.xml
Mike,
What about...
<!-- can't have "no" + "commit" in file or we'll fail our own check -->
<property name="at" value="@">
<property name="no" value="no">
<property name="commit" value="commit">
...
<fail if="validate.patternsFound">The following files contain ${at}author tags, tabs, svn keywords or ${no}${commit}:${line.separator}${validate.patternsFound}</fail>
?
: Date: Thu, 21 Aug 2014 23:44:17 -0000
: From: mikemccand@apache.org
: Reply-To: dev@lucene.apache.org
: To: commits@lucene.apache.org
: Subject: svn commit: r1619630 - in /lucene/dev/branches/branch_4x: ./
: build.xml
:
: Author: mikemccand
: Date: Thu Aug 21 23:44:16 2014
: New Revision: 1619630
:
: URL: http://svn.apache.org/r1619630
: Log:
: hmm, can't check .xml yet
:
: Modified:
: lucene/dev/branches/branch_4x/ (props changed)
: lucene/dev/branches/branch_4x/build.xml
:
: Modified: lucene/dev/branches/branch_4x/build.xml
: URL: http://svn.apache.org/viewvc/lucene/dev/branches/branch_4x/build.xml?rev=1619630&r1=1619629&r2=1619630&view=diff
: ==============================================================================
: --- lucene/dev/branches/branch_4x/build.xml (original)
: +++ lucene/dev/branches/branch_4x/build.xml Thu Aug 21 23:44:16 2014
: @@ -81,7 +81,6 @@
: <fileset dir="${validate.currDir}">
: <include name="**/*.java"/>
: <include name="**/*.py"/>
: - <include name="**/*.xml"/>
: <exclude name="**/backwards/**"/>
: <or>
: <containsregexp expression="@author\b" casesensitive="yes"/>
:
:
:
-Hoss
http://www.lucidworks.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: svn commit: r1619630 - in /lucene/dev/branches/branch_4x: ./
build.xml
Posted by Chris Hostetter <ho...@fucit.org>.
:
: Thanks Hoss, that would fix this one false failure ... but there were
: many false failures (I think from tabs?), but I didn't look very
: closely.
i didn't try it, i was just guessing the obvious problem based on your
fast revert.
tabs could easily be fixed ... the no+commit and @+author issues are hte
only things i can think of that would need a creative solution if you're
interested in trying to add it back.
:
: Mike McCandless
:
: http://blog.mikemccandless.com
:
:
: On Fri, Aug 22, 2014 at 12:58 PM, Chris Hostetter
: <ho...@fucit.org> wrote:
: >
: > Mike,
: >
: > What about...
: >
: > <!-- can't have "no" + "commit" in file or we'll fail our own check -->
: > <property name="at" value="@">
: > <property name="no" value="no">
: > <property name="commit" value="commit">
: > ...
: > <fail if="validate.patternsFound">The following files contain ${at}author tags, tabs, svn keywords or ${no}${commit}:${line.separator}${validate.patternsFound}</fail>
: >
: >
: > ?
: >
: >
: > : Date: Thu, 21 Aug 2014 23:44:17 -0000
: > : From: mikemccand@apache.org
: > : Reply-To: dev@lucene.apache.org
: > : To: commits@lucene.apache.org
: > : Subject: svn commit: r1619630 - in /lucene/dev/branches/branch_4x: ./
: > : build.xml
: > :
: > : Author: mikemccand
: > : Date: Thu Aug 21 23:44:16 2014
: > : New Revision: 1619630
: > :
: > : URL: http://svn.apache.org/r1619630
: > : Log:
: > : hmm, can't check .xml yet
: > :
: > : Modified:
: > : lucene/dev/branches/branch_4x/ (props changed)
: > : lucene/dev/branches/branch_4x/build.xml
: > :
: > : Modified: lucene/dev/branches/branch_4x/build.xml
: > : URL: http://svn.apache.org/viewvc/lucene/dev/branches/branch_4x/build.xml?rev=1619630&r1=1619629&r2=1619630&view=diff
: > : ==============================================================================
: > : --- lucene/dev/branches/branch_4x/build.xml (original)
: > : +++ lucene/dev/branches/branch_4x/build.xml Thu Aug 21 23:44:16 2014
: > : @@ -81,7 +81,6 @@
: > : <fileset dir="${validate.currDir}">
: > : <include name="**/*.java"/>
: > : <include name="**/*.py"/>
: > : - <include name="**/*.xml"/>
: > : <exclude name="**/backwards/**"/>
: > : <or>
: > : <containsregexp expression="@author\b" casesensitive="yes"/>
: > :
: > :
: > :
: >
: > -Hoss
: > http://www.lucidworks.com/
: >
: > ---------------------------------------------------------------------
: > To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
: > For additional commands, e-mail: dev-help@lucene.apache.org
: >
:
: ---------------------------------------------------------------------
: To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
: For additional commands, e-mail: dev-help@lucene.apache.org
:
:
-Hoss
http://www.lucidworks.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: svn commit: r1619630 - in /lucene/dev/branches/branch_4x: ./ build.xml
Posted by Michael McCandless <lu...@mikemccandless.com>.
Thanks Hoss, that would fix this one false failure ... but there were
many false failures (I think from tabs?), but I didn't look very
closely.
Mike McCandless
http://blog.mikemccandless.com
On Fri, Aug 22, 2014 at 12:58 PM, Chris Hostetter
<ho...@fucit.org> wrote:
>
> Mike,
>
> What about...
>
> <!-- can't have "no" + "commit" in file or we'll fail our own check -->
> <property name="at" value="@">
> <property name="no" value="no">
> <property name="commit" value="commit">
> ...
> <fail if="validate.patternsFound">The following files contain ${at}author tags, tabs, svn keywords or ${no}${commit}:${line.separator}${validate.patternsFound}</fail>
>
>
> ?
>
>
> : Date: Thu, 21 Aug 2014 23:44:17 -0000
> : From: mikemccand@apache.org
> : Reply-To: dev@lucene.apache.org
> : To: commits@lucene.apache.org
> : Subject: svn commit: r1619630 - in /lucene/dev/branches/branch_4x: ./
> : build.xml
> :
> : Author: mikemccand
> : Date: Thu Aug 21 23:44:16 2014
> : New Revision: 1619630
> :
> : URL: http://svn.apache.org/r1619630
> : Log:
> : hmm, can't check .xml yet
> :
> : Modified:
> : lucene/dev/branches/branch_4x/ (props changed)
> : lucene/dev/branches/branch_4x/build.xml
> :
> : Modified: lucene/dev/branches/branch_4x/build.xml
> : URL: http://svn.apache.org/viewvc/lucene/dev/branches/branch_4x/build.xml?rev=1619630&r1=1619629&r2=1619630&view=diff
> : ==============================================================================
> : --- lucene/dev/branches/branch_4x/build.xml (original)
> : +++ lucene/dev/branches/branch_4x/build.xml Thu Aug 21 23:44:16 2014
> : @@ -81,7 +81,6 @@
> : <fileset dir="${validate.currDir}">
> : <include name="**/*.java"/>
> : <include name="**/*.py"/>
> : - <include name="**/*.xml"/>
> : <exclude name="**/backwards/**"/>
> : <or>
> : <containsregexp expression="@author\b" casesensitive="yes"/>
> :
> :
> :
>
> -Hoss
> http://www.lucidworks.com/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org