You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/04/01 02:17:59 UTC
[GitHub] [shardingsphere] sandynz opened a new pull request #9894: Fix 9892 : RegisterCenter.renew(DataSourceAddedEvent e) throw UnsupportedOperationException when RDL add resource
sandynz opened a new pull request #9894:
URL: https://github.com/apache/shardingsphere/pull/9894
Fixes #9892.
Changes proposed in this pull request:
- wrap result map with LinkedHashMap to support `put`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #9894: Fix 9892 : RegisterCenter.renew(DataSourceAddedEvent e) throw UnsupportedOperationException when RDL add resource
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #9894:
URL: https://github.com/apache/shardingsphere/pull/9894
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on a change in pull request #9894: Fix 9892 : RegisterCenter.renew(DataSourceAddedEvent e) throw UnsupportedOperationException when RDL add resource
Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #9894:
URL: https://github.com/apache/shardingsphere/pull/9894#discussion_r605689673
##########
File path: shardingsphere-governance/shardingsphere-governance-core/src/main/java/org/apache/shardingsphere/governance/core/registry/RegistryCenter.java
##########
@@ -148,6 +148,7 @@ public void persistDataSourceConfigurations(final String schemaName, final Map<S
private void addDataSourceConfigurations(final String schemaName, final Map<String, DataSourceConfiguration> dataSourceConfigurations) {
Map<String, DataSourceConfiguration> dataSourceConfigurationMap = loadDataSourceConfigurations(schemaName);
+ dataSourceConfigurationMap = new LinkedHashMap<>(dataSourceConfigurationMap);
Review comment:
How about we fix this issue in `convertDataSourceConfigurations()` of `YamlConfigurationConverter`? It looks a little puzzled that `new LinkedHashMap<>(dataSourceConfigurationMap)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz commented on a change in pull request #9894: Fix 9892 : RegisterCenter.renew(DataSourceAddedEvent e) throw UnsupportedOperationException when RDL add resource
Posted by GitBox <gi...@apache.org>.
sandynz commented on a change in pull request #9894:
URL: https://github.com/apache/shardingsphere/pull/9894#discussion_r605721349
##########
File path: shardingsphere-governance/shardingsphere-governance-core/src/main/java/org/apache/shardingsphere/governance/core/registry/RegistryCenter.java
##########
@@ -148,6 +148,7 @@ public void persistDataSourceConfigurations(final String schemaName, final Map<S
private void addDataSourceConfigurations(final String schemaName, final Map<String, DataSourceConfiguration> dataSourceConfigurations) {
Map<String, DataSourceConfiguration> dataSourceConfigurationMap = loadDataSourceConfigurations(schemaName);
+ dataSourceConfigurationMap = new LinkedHashMap<>(dataSourceConfigurationMap);
Review comment:
That's ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org